git-core: error: incomplete definition of type 'struct ustar_header'

[ryandesign (Ryan Carsten Schmidt)]

Installing git-core @1.8.1 fails:

builtin/tar-tree.c:93:12: error: incomplete definition of type 'struct ustar_header'
        if (header->typeflag[0] != 'g')
            ~~~~~~^
builtin/tar-tree.c:83:9: note: forward declaration of 'struct ustar_header'
        struct ustar_header *header = (struct ustar_header *)buffer;
               ^

[ryandesign (Ryan Carsten Schmidt)]

The build fails when the libc-headers port is installed and active, because libc-headers provides /opt/local/include/tar.h. This tells us that the "-I" flags are not in the right order:

/usr/bin/clang -o builtin/tar-tree.o -c -MF builtin/.depend/tar-tree.o.d -MMD -MP  -Wall -O2 -I/opt/local/include -arch x86_64 -I. -DPRECOMPOSE_UNICODE -DUSE_LIBPCRE -I/opt/local/include -I/opt/local/include -I/opt/local/include -I/opt/local/include -DUSE_ST_TIMESPEC  -DHAVE_DEV_TTY -DXDL_FAST_HASH -DSHA1_HEADER='<openssl/sha.h>'  -DNO_MEMMEM -DSHELL_PATH='"/bin/sh"'  builtin/tar-tree.c

Note how "-I/opt/local/include" appears before "-I.".

[larryv (Lawrence Velázquez)]

Cc Me!

[ci42]

r101324

[cooljeanius (Eric Gallager)]

Cc Me!