xdm @1.1.11_0: error: security/pam_appl.h: No such file or directory

[johanmattssonm (Johan Mattsson)]

xdm fails to build;

:info:build In file included from chooser.c:63:
:info:build ../include/dm.h:108:33: error: security/pam_appl.h: No such file or directory
:info:build In file included from chooser.c:63:
:info:build ../include/dm.h:427: error: syntax error before ‘*’ token
:info:build ../include/dm.h:427: warning: type defaults to ‘int’ in declaration of ‘thepamhp’
:info:build ../include/dm.h:427: warning: data definition has no type or storage class
:info:build ../include/dm.h:428: error: syntax error before ‘*’ token
:info:build ../include/dm.h:428: warning: type defaults to ‘int’ in declaration of ‘thepamh’
:info:build ../include/dm.h:428: warning: data definition has no type or storage class

[jeremyhu (Jeremy Huddleston Sequoia)]

You should have it at /usr/include/security/pam_appl.h ... I see it on my SL, Lion, and ML boxes. Make sure you've got a sane build environment.

[jeremyhu (Jeremy Huddleston Sequoia)]

(ie: Install XCode and the command line tools)

[jeremyhu (Jeremy Huddleston Sequoia)]

Oh, I see in main.log that you're using Leopard. You should really call that out in your bug report.

[jeremyhu (Jeremy Huddleston Sequoia)]

Over to ryan to look at since he's got Leopard boxes still.

[jeremyhu (Jeremy Huddleston Sequoia)]

Cc Me!

[johanmattssonm (Johan Mattsson)]

Replying to jeremyhu@…:

You should have it at /usr/include/security/pam_appl.h ... I see it on my SL, Lion, and ML boxes. Make sure you've got a sane build environment.

I do have pam_appl.h:

m83-180-167-138:bin johanmattsson$ ls /usr/include/pam/pam_appl.h 
/usr/include/pam/pam_appl.h

I don't know what else that might be needed.

Cheers

[johanmattssonm (Johan Mattsson)]

I disabled pam support in the config file. Xdm builds now,

[ryandesign (Ryan Carsten Schmidt)]

xpm was already successfully installed on my Leopard i386 machine. I just rebuilt it to verify it still builds. I haven't yet compared the failed log attached here with mine.

[jeremyhu (Jeremy Huddleston Sequoia)]

xpm != xdm

[ryandesign (Ryan Carsten Schmidt)]

Indeed! Ok, xdm fails for me as it does for the reporter. The project seems hardcoded to #include <security/pam_appl.h>. I'll check if changing that to <pam/pam_appl.h> is all that's needed for Leopard.

[ryandesign (Ryan Carsten Schmidt)]

Yes that seems to work. This patch is messy because it must be conditionally applied only on Leopard and lower. Is that ok or should we rewrite it to use some #if logic so that it can be applied always?

[jeremyhu (Jeremy Huddleston Sequoia)]

r102011 and ​http://cgit.freedesktop.org/xorg/app/xdm/commit/?id=fa8adede758e2b1e8ae38c84d032b354f0250f49