gnome-keyring does not compile AM_CONFIG_HEADER should be AC_CONFIG_HEADERS

[wink@…]

I was trying to install meld and it depends on gnome-keyring. Which failed to compile, looking at the log file I saw:

:info:configure configure.in:4: error: 'AM_CONFIG_HEADER': this macro is obsolete.
:info:configure     You should use the 'AC_CONFIG_HEADERS' macro instead.
:info:configure /opt/local/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expanded from...

So I manually changed gnome-keyring's configure.in file to use AC_CONFIG_HEADERS, this allowed the compile to succeed. Also, looking around I find quite a few patches using this file:

$ cat  ./sources/rsync.macports.org/release/tarballs/ports/gnome/gnome-mime-data/files/patch-automake-1.13.diff

$ cat ./sources/rsync.macports.org/release/tarballs/ports/gnome/gnome-mime-data/files/patch-automake-1.13.diff
--- configure.in.orig	2007-04-03 12:34:00.000000000 -0500
+++ configure.in	2013-01-02 07:49:48.000000000 -0600
@@ -3,7 +3,7 @@
 AC_CONFIG_SRCDIR(check-mime.pl)
 
 AM_INIT_AUTOMAKE
-AM_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS([config.h])
 AM_MAINTAINER_MODE
 AC_SUBST(ACLOCAL_AMFLAGS, "\${ACLOCAL_FLAGS}")

It would seem this same patch is needed for gnome-keyring.

[ryandesign (Ryan Carsten Schmidt)]

Duplicate of #37428. This was fixed in December. Please run "sudo port selfupdate" to receive this and other fixes.

Yes, many ports need to be patched to be compatible with automake 1.13 and up. Yes, many ports have patchfiles with the name patch-automake-1.13.diff to do this. But each port needs a different patch. The patchfiles are only named the same to make it clear what the patch is for.

Please remember to use WikiFormatting when writing in Trac, and to fill in the Port and Cc fields properly. See the ticket filing instructions linked prominently at the top of the New Ticket page.

[wink@…]

Replying to ryandesign@…:

Duplicate of #37428. This was fixed in December. Please run "sudo port selfupdate" to receive this and other fixes.

Yes, many ports need to be patched to be compatible with automake 1.13 and up. Yes, many ports have patchfiles with the name patch-automake-1.13.diff to do this. But each port needs a different patch. The patchfiles are only named the same to make it clear what the patch is for.

Please remember to use WikiFormatting when writing in Trac, and to fill in the Port and Cc fields properly. See the ticket filing instructions linked prominently at the top of the New Ticket page.

Interesting I had done a "sudo port selfupdate" but was still getting the error. I checked and I now have the the patch referenced in the 37428, so I'm not sure what happened.

Thanks for responding.

[ryandesign (Ryan Carsten Schmidt)]

Perhaps you had not cleaned gnome-keyring before trying again (#29223).