Opened 12 years ago
Last modified 4 months ago
#37797 new submission
New port: portfile-gen
| Reported by: | cooljeanius (Eric Gallager) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | Cc: | ||
| Port: | portfile-gen |
Description
From the contrib folder on svn. Pretty similar to the portfile I wrote for port-depgraph in #37721
Attachments (3)
Change History (13)
comment:1 follow-up: 2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 12 years ago by cooljeanius (Eric Gallager)
OK, new portfile attached.
Replying to ryandesign@…:
Thanks. A few observations:
- The Portfile says the version is "0.1.0 " but the script says it's "0.1".
Changed to 0.2 actually, seeing as you bumped it in r102075. Since you were the last one to edit it, I added you as a maintainer, too (I hope that's okay with you)
- There is no distfile, so "dist_subdir" is not needed.
Removed.
- A dependency on port:tcl is added, but it is not used; either patch the script to use MacPorts Tcl in the first line, or remove the dependency. Assuming the script doesn't do anything that requires Tcl newer than 8.4, I'd favor the latter, since MacPorts itself uses the system's Tcl, not MacPorts Tcl.
Removed.
- Indentations should be at multiples of 4 spaces.
Too lazy to fix this one myself... feel free to change it yourself though.
comment:3 follow-up: 4 Changed 10 years ago by cooljeanius (Eric Gallager)
(Note to self: need to update port for MacPorts 2.3.0)
comment:4 Changed 10 years ago by cooljeanius (Eric Gallager)
Replying to egall@…:
(Note to self: need to update port for MacPorts 2.3.0)
Actually upon double-checking this, the port uses the system tclsh (i.e. /usr/bin/tclsh), so it does not actually need to be updated for MacPorts 2.3.0. I am still attaching a new Portfile that bumps it to the latest revision in which it was modified (i.e. r114218) though.
Changed 10 years ago by cooljeanius (Eric Gallager)
| Attachment: | Portfile.2 added |
|---|
Portfile for portfile-gen as of r114218
Changed 10 years ago by cooljeanius (Eric Gallager)
| Attachment: | Portfile.diff added |
|---|
diff between the first Portfile that I attached and the one I just attached now
comment:5 follow-up: 6 Changed 10 years ago by mf2k (Frank Schima)
Some notes:
- The revision line needs to be deleted.
- I don't see the point of the ui_debug line in the empty build phase. Many ports lack a build phase and don't say as much.
comment:6 follow-up: 7 Changed 10 years ago by cooljeanius (Eric Gallager)
Replying to mf2k@…:
Some notes:
- The revision line needs to be deleted.
I agree that the revision needs to be deleted for trunk, but I need to keep the revision in my local repository to make sure that MacPorts can tell that it is newer than previously versions that I have installed. Feel free to remove the revision line when committing it to trunk though.
- I don't see the point of the ui_debug line in the empty build phase. Many ports lack a build phase and don't say as much.
Yeah, I used to leave the build phase completely empty previously, too, based on the other ports that did as such, but I just kind of felt uncomfortable leaving it like that. Doing it this way makes it clearer that the build phase is being skipped intentionally. It is mostly just a personal taste thing though, so feel free to remove the line when committing it to trunk.
comment:7 Changed 10 years ago by mf2k (Frank Schima)
Replying to egall@…:
Replying to mf2k@…:
Some notes:
- The revision line needs to be deleted.
I agree that the revision needs to be deleted for trunk, but I need to keep the revision in my local repository to make sure that MacPorts can tell that it is newer than previously versions that I have installed. Feel free to remove the revision line when committing it to trunk though.
You don't "need" to do that. Simply uninstall and reinstall the port locally.
comment:8 follow-up: 9 Changed 13 months ago by cooljeanius (Eric Gallager)
PR submitted: https://github.com/macports/macports-ports/pull/20951
comment:9 Changed 4 months ago by cooljeanius (Eric Gallager)
Replying to cooljeanius:
PR submitted: https://github.com/macports/macports-ports/pull/20951
Update: this PR was unjustly closed despite being perfectly correct; I call on someone with the proper permissions to reopen and merge it.
comment:10 Changed 4 months ago by reneeotten (Renee Otten)
The PR had been open for ~8 months and you were asked to make changes to conform to standard MacPorts' practices but refused. At some point there is no reason to keep things open that are not making any progress. The request to remove unneeded debug messages in steps that are not used was also made in PR 20971 and it's not difficult to comply with.
Thanks. A few observations: