Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#37825 closed submission (fixed)

New port: mpvim

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: larryv (Lawrence Velázquez)
Port: mpvim

Description

From the contrib folder on svn.

Attachments (2)

Portfile​ (1.0 KB) - added by cooljeanius (Eric Gallager) 12 years ago.
portfile for mpvim
Portfile.2​ (1008 bytes) - added by cooljeanius (Eric Gallager) 12 years ago.
New portfile for mpvim

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile​ added

portfile for mpvim

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

  • Was the version number "0.1.0" invented by you or does it actually say that somewhere in the mpvim sources? I couldn't find it.
  • "make install" is what MacPorts does in the destroot phase by default; you don't need to override the destroot block for that.
  • In the build phase, MacPorts by default runs "make all", which it looks like the mpvim Makefile supports, so you don't need to override the build phase.
  • Instead of using a configure block and running a reinplace, it looks like the Makefile is designed for you to set the "prefix" environment variable at install time (e.g. in destroot.env); you can use "use_configure no" to tell MacPorts not to run the configure phase.

comment:2 in reply to:  1 ; Changed 12 years ago by cooljeanius (Eric Gallager)

Replying to ryandesign@…:

  • Was the version number "0.1.0" invented by you or does it actually say that somewhere in the mpvim sources? I couldn't find it.

Well I had to put something for the version number... what do you think it should be instead?

  • "make install" is what MacPorts does in the destroot phase by default; you don't need to override the destroot block for that.
  • Instead of using a configure block and running a reinplace, it looks like the Makefile is designed for you to set the "prefix" environment variable at install time (e.g. in destroot.env); you can use "use_configure no" to tell MacPorts not to run the configure phase.

I haven't had a chance to update the portfile yet in response to the changes that larryv's made in the makefile in r102169. There was no "prefix" variable in the makefile before that.

Changed 12 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile.2​ added

New portfile for mpvim

comment:3 in reply to:  2 Changed 12 years ago by cooljeanius (Eric Gallager)

Replying to egall@…:

I haven't had a chance to update the portfile yet in response to the changes that larryv's made in the makefile in r102169.

Now I have though, the latest portfile attached fixes this.

comment:4 Changed 12 years ago by neverpanic (Clemens Lang)

Resolution: → fixed
Status: new → closed

Commited in r103385 with the following changes:

  • Used the revision as version number
  • Added livecheck

comment:5 Changed 12 years ago by cooljeanius (Eric Gallager)

Thanks cal!

Note: See TracTickets for help on using tickets.