webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined

[ryandesign (Ryan Carsten Schmidt)]

Building webkit-gtk @1.10.2 fails on Tiger ppc with:

In file included from ./Source/JavaScriptCore/config.h:30,
                 from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:
./Source/WTF/wtf/Platform.h:710:22: warning: "__MAC_OS_X_VERSION_MIN_REQUIRED" is not defined
./Source/JavaScriptCore/heap/ListableHandler.h:58: error: ?class JSC::ListableHandler<JSC::WeakReferenceHarvester>::List? is private
./Source/JavaScriptCore/heap/GCThreadSharedData.h:78: error: within this context
./Source/JavaScriptCore/heap/ListableHandler.h:58: error: ?class JSC::ListableHandler<JSC::UnconditionalFinalizer>::List? is private
./Source/JavaScriptCore/heap/GCThreadSharedData.h:79: error: within this context

[jeremyhu (Jeremy Huddleston Sequoia)]

__MAC_OS_X_VERSION_MIN_REQUIRED is set by AvailabilityInternal.h, which isn't on Tiger. Try adding this and trying again:

configure.cppflags-append -D__MAC_OS_X_VERSION_MIN_REQUIRED=1040

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

configure.cppflags-append -D__MAC_OS_X_VERSION_MIN_REQUIRED=1040

That gets rid of the warning, but the errors shown in the description remain.

The errors look similar to ones we had with an old version of harfbuzz: ​http://lists.freedesktop.org/archives/harfbuzz/2012-October/002592.html
To "fix" it they just marked the members as non-private: ​http://cgit.freedesktop.org/harfbuzz/commit/?id=365f27ab5ba025bf1be6a882ed213c695cbfed7e

[jeremyhu (Jeremy Huddleston Sequoia)]

I pushed the __MAC_OS_X_VERSION_MIN_REQUIRED change. Can you try a patch marking JSC::ListableHandler<*>::List as a public class?

Also, would you mind testing webkit-gtk-1.11.4:

git clone git://github.com/jeremyhu/dports_jeremyhu.git
cd dports_jeremyhu
portindex

Then just add ​file:///path/to/dports_jeremyhu to /opt/local/etc/macports/sources.conf

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

Can you try a patch marking JSC::ListableHandler<*>::List as a public class?

I've tried the patch I've attached here now. It got me further (#37882).

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

Also, would you mind testing webkit-gtk-1.11.4:

It depends on harfbuzz which depends on graphite2 which does not build on Tiger because of an unrecognized compiler flag and I don't know what the flag is supposed to do or whether I can just remove it or what: ​https://sourceforge.net/tracker/?func=detail&aid=3597386&group_id=66144&atid=513479

[ryandesign (Ryan Carsten Schmidt)]

(And I'd love to get that graphite2 issue fixed because it's the last issue I know of preventing updating MacPorts pango to 1.32.5)

[jeremyhu (Jeremy Huddleston Sequoia)]

r102364 for this particular issue.

[jeremyhu (Jeremy Huddleston Sequoia)]

Just remove -fno-stack-protecto from CFLAGS on Tiger and you should be fine.

[jeremyhu (Jeremy Huddleston Sequoia)]

r102365 for graphite2.

[cooljeanius (Eric Gallager)]

Cc Me!