Opened 12 years ago
Closed 12 years ago
#37837 closed update (fixed)
kdenlive upgrade to 0.9.4
Reported by: | ddennedy (Dan Dennedy) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.2 |
Keywords: | maintainer haspatch | Cc: | |
Port: | kdenlive |
Description
Kdenlive upgrade to v0.9.4.
Attachments (3)
Change History (7)
Changed 12 years ago by ddennedy (Dan Dennedy)
Attachment: | kdenlive-0.9.4-Portfile.diff added |
---|
Changed 12 years ago by ddennedy (Dan Dennedy)
Attachment: | patch-src-stringMap.diff added |
---|
patch to fix a build problem
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Is this new patch also Darwin-specific or should it be in the global part of the Portfile?
comment:2 Changed 12 years ago by ddennedy (Dan Dennedy)
Oh, shit. I did not even see that and did not know MacPorts was doing anything other than Darwin. It is not Darwin-specific. It is apparently qt moc-version/bug-specific. But I am not testing freebsd or supporting that, which is why the Portfile still says "platforms darwin." Should we move the patch out of its block?
Changed 12 years ago by ddennedy (Dan Dennedy)
Attachment: | kdenlive-0.9.4-Portfile.2.diff added |
---|
portfile patch v2
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Status: | new → assigned |
MacPorts is primarily for Darwin, more specifically OS X, but people might conceivably try to use it on other systems. Point is, the purpose of the "platform darwin" block is to indicate things which are known to be specific to Darwin, which this patch as far as I can tell is not.
Note that the "platforms" line is not used by MacPorts, other than in the output of "port info"; it doesn't, for example, prevent the port from being installed on other OSes.
The "platform darwin" block will need to be modified to append to, instead of replace, the patchfiles.
comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
portfile patch