x264 @20130105: needs revbump after ffmpeg upgrade

[mklein-de (Michael Klein)]

$ sudo port -v rev-upgrade
--->  Scanning binaries for linking errors: 59.0%
Could not open /opt/local/lib/libavutil.51.dylib: Error opening or reading file (referenced from /opt/local/bin/x264)
--->  Scanning binaries for linking errors: 66.8%
Could not open /opt/local/lib/libgraph.5.dylib: Error opening or reading file (referenced from /opt/local/lib/ImageMagick-6.8.0/modules-Q16/coders/dot.so)
--->  Scanning binaries for linking errors: 100.0%
--->  Found 2 broken file(s), matching files to ports
--->  Found 2 broken port(s):
     x264 @20130105 
         /opt/local/bin/x264
     ImageMagick @6.8.0-7 +graphviz+q16+rsvg
         /opt/local/lib/ImageMagick-6.8.0/modules-Q16/coders/dot.so

$ port contents ffmpeg | grep libavutil.*dylib
  /opt/local/lib/libavutil.52.13.100.dylib
  /opt/local/lib/libavutil.52.dylib
  /opt/local/lib/libavutil.dylib

[larryv (Lawrence Velázquez)]

Thanks for the ticket.

[mkae (Marko Käning)]

Cc Me!

[mkae (Marko Käning)]

fixed with r102353

[jmroot (Joshua Root)]

Why was x264 linking against libavutil in the first place? It supposedly has no dependencies.

[mkae (Marko Käning)]

That was irritating me too. Looks like x264 needs an update regarding its deps...

[mkae (Marko Käning)]

See #37900.

[mkae (Marko Käning)]

See also #37347

[neverpanic (Clemens Lang)]

x264 should not have a dependency on ffmpeg and it should also not have been revbumped. Since I fixed #37347 in r101514 x264 should not have linked against ffmpeg. If it did anyway, that's something we need to take care of.

However, it seems to me the output above does mention an outdated version of x264 (in specific, "@20130105", where current is "@20130105_1", which contains the fix from #37347).

So in this case the reporter should have run rev-upgrade in rebuild mode, which should have left him with a x264 not depending on ffmpeg. This ticket should have been closed invalid.