mailx @12.4_2: build failure

[benw04@…]

mailx fails to compile with the following error:

$ sudo port upgrade outdated
--->  Computing dependencies for mailx
--->  Fetching archive for mailx
--->  Attempting to fetch mailx-12.4_2.darwin_11.x86_64.tbz2 from http://jog.id.packages.macports.org/macports/packages/mailx
--->  Attempting to fetch mailx-12.4_2.darwin_11.x86_64.tbz2 from http://packages.macports.org/mailx
--->  Attempting to fetch mailx-12.4_2.darwin_11.x86_64.tbz2 from http://lil.fr.packages.macports.org/mailx
--->  Fetching distfiles for mailx
--->  Verifying checksum(s) for mailx
--->  Extracting mailx
--->  Applying patches to mailx
--->  Configuring mailx
--->  Building mailx
Error: org.macports.build for port mailx returned: command execution failed
Please see the log file for port mailx for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_mail_mailx/mailx/main.log                                                                                                                          │
Error: Unable to upgrade port: 1

main.log has these messages:

:info:build /usr/bin/clang -O2 -arch x86_64  -DMAILRC='"/opt/local/etc/nail.rc"' -DMAILSPOOL='"/var/mail"' -DSENDMAIL='"/usr/sbin/sendmail"'   -Wall -Wno-parentheses -Werror -c mime.c
:info:build mime.c:753:12: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
:info:build         if (limit < 0 || limit > 950)
:info:build             ~~~~~ ^ ~
:info:build 1 error generated.
:info:build make: *** [mime.o] Error 1
:info:build make: *** Waiting for unfinished jobs....
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_mail_mailx/mailx/work/mailx-12.4'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_mail_mailx/mailx/work/mailx-12.4" && /usr/bin/make -j2 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port mailx returned: command execution failed
:debug:build Error code: CHILDSTATUS 19633 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
:info:build Warning: targets not executed for mailx: org.macports.install org.macports.build org.macports.destroot
:notice:build Please see the log file for port mailx for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_mail_mailx/mailx/main.log

[larryv (Lawrence Velázquez)]

Thanks for the ticket. In the future, please Cc relevant port maintainers.

[jmroot (Joshua Root)]

Should just need to remove -Werror from patch-Makefile.

[jmroot (Joshua Root)]

r102805 (maintainer timeout)

[ryandesign (Ryan Carsten Schmidt)]

Users who encountered this problem, then selfupdated, then tried again would still experience the failure because since the Portfile had not changed, MacPorts would not know that it should clean the work area. I made an unrelated change to the Portfile in r102825 to make the process more seamless for users.