libsdl_image 1.2.12: fails to load some .png images on 10.5

[mklein-de (Michael Klein)]

Trying to run circuslinux on Leopard (PPC):

$ circuslinux                                                             

Error: I couldn't load a graphics file:
/opt/local/share/circuslinux/data/images/title/programming.png
The Simple DirectMedia error that occured was:
Unknown bits_per_pixel u

The error is returned from IMG_Load and can be reproduced with just few lines of C:

#include <SDL_error.h>
#include <SDL_image.h>
#include <stdio.h>

int SDL_main(int argc, char *argv[])
{
    char **p;
    for (p = argv+1; *p; p++)
    {
        printf("%s -> %p, %s\n", *p, IMG_Load(*p), SDL_GetError());
        SDL_ClearError();
    }
    return 0;
}

$ cc `pkg-config --cflags SDL_image`  `pkg-config --libs SDL_image`  imgload.c   -o imgload

Some images from circuslinux load ok, some don't:

$ ./imgload /opt/local/share/circuslinux/data/images/title/*              
/opt/local/share/circuslinux/data/images/title/graphics.png -> 0x0, Unknown bits_per_pixel u
/opt/local/share/circuslinux/data/images/title/light-off.png -> 0x250790, 
/opt/local/share/circuslinux/data/images/title/light-on.png -> 0x250910, 
/opt/local/share/circuslinux/data/images/title/music.png -> 0x0, Unknown bits_per_pixel u
/opt/local/share/circuslinux/data/images/title/programming.png -> 0x0, Unknown bits_per_pixel u
/opt/local/share/circuslinux/data/images/title/title-highlights.png -> 0x250800, 
/opt/local/share/circuslinux/data/images/title/title.png -> 0x251630, 

The "Unknown bits_per_pixel" error comes from IMG_ImageIO.m.

As a workaround I disabled ImageIO support in libsdl_image, all files load ok now.

[mklein-de (Michael Klein)]

add disable_imageio variant

[ryandesign (Ryan Carsten Schmidt)]

Variant names should not begin with words like "disable".

[jmroot (Joshua Root)]

Is there an upstream bug report?

[mklein-de (Michael Klein)]

Replying to jmr@…:

Is there an upstream bug report?

​http://bugzilla.libsdl.org/show_bug.cgi?id=1721

[ttimo@…]

duplicate of #37453

[jmroot (Joshua Root)]

I don't think this is a dupe. I confirmed in a VM that the fix for #37453 does not fix this problem. Also this one does not affect OS versions newer than 10.5 but #37453 does.

Disabled ImageIO on 10.5 in r148198.