ndmanager-plugins @1.4.6

[FlorianFranzen@…]

Port attached. Since I use this software myself I would be interested in also maintaining it.

This port can not be installed without running install twice, because of docbook and xslt. The offical bug report to the error that occurs just suggests to run make again, which is pretty much what happens if you run install again. I added a waring to the configure step, to tell the user about it.

Furthermore the original source uses locate to find the docbook xsl files. Therefore the locate database must be up to date or updated prior to the installation. The configure step therefore issues a warning to the user.

The python based plugins could not be ported due to a pyQt dependency, I therefore disabled them completely.

[FlorianFranzen@…]

Cc Me!

[FlorianFranzen@…]

Fixed maintainer, indentation and distfiles value.

[g5pw (Aljaž Srebrnič)]

Ok, I checked the portfile and there are a few issues still:

• all the patching with sed in the configure phase should be done in the pre- or post-patch phase. They need to be done the Tcl way, using reinplace and the file command.
• if the port does not have a configure phase, use_configure no should be used.
• if there is no configure phase, care must be taken to ensure we are [UsingTheRightCompiler].
• why does the success of compilation rely on locate?!?
• messages should be printed in pre-configure, or you could add notes with the notes "note text" command.

[FlorianFranzen@…]

Replying to g5pw@…:

• all the patching with sed in the configure phase should be done in the pre- or post-patch phase. They need to be done the Tcl way, using reinplace and the file command.

Sure, I can look into that.

• if the port does not have a configure phase, use_configure no should be used.
• if there is no configure phase, care must be taken to ensure we are [UsingTheRightCompiler].

I will look into that as well, but it well be a loot of patching, since only manual created makefiles are used.

• why does the success of compilation rely on locate?!?

I really dont know the design decision behind it. It is used to locate the docbook files to build the documentation. I rather updated locate db instead of trying to add a hard coded path, but I agree that it rather a "works-for-me" kind of fix.

• messages should be printed in pre-configure, or you could add notes with the notes "note text" command.

Ok, I did not know that. I will add it.

[g5pw (Aljaž Srebrnič)]

Replying to FlorianFranzen@…:

Replying to g5pw@…:

• if the port does not have a configure phase, use_configure no should be used.
• if there is no configure phase, care must be taken to ensure we are [UsingTheRightCompiler].

I will look into that as well, but it well be a loot of patching, since only manual created makefiles are used.

Hmm.. What do you mean by that? Can't we just set $(CC) to specify a compiler?

• why does the success of compilation rely on locate?!?

I really dont know the design decision behind it. It is used to locate the docbook files to build the documentation. I rather updated locate db instead of trying to add a hard coded path, but I agree that it rather a "works-for-me" kind of fix.

Well, the usual way to go at it is to use find or better, fs-traverse.