Opened 12 years ago
Closed 13 months ago
#38159 closed submission (fixed)
New port: gaa
Reported by: | cooljeanius (Eric Gallager) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.3 |
Keywords: | Cc: | ||
Port: | gaa |
Description
I saw a link to gaa's sourceforge scrolling by in some port's configure script (I forget which one), so I went to see if there was a port already for it, and I was surprised to find that there wasn't one yet, so I went and forked the project to my Github, patched it up and got it to build, and then wrote a portfile for it, which is attached.
Attachments (2)
Change History (13)
Changed 12 years ago by cooljeanius (Eric Gallager)
comment:1 follow-up: 2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
- Did you have to change a lot? Have these changes been contributed back to the developers?
- Why is the autoreconf variant needed?
comment:2 Changed 12 years ago by cooljeanius (Eric Gallager)
Replying to ryandesign@…:
- Did you have to change a lot? Have these changes been contributed back to the developers?
I don't think the original developers exist any more, the Sourceforge project hasn't been updated since 2002. The only change I made to the actual code was to rename one function so it didn't conflict with a function included from <stdio.h>; the rest of the changes were just me adding more checks to the build system and modernizing it and stuff.
- Why is the autoreconf variant needed?
It isn't; feel free to remove it if you don't want it. I just personally like to run autoreconf before configuring stuff.
comment:3 follow-up: 4 Changed 12 years ago by larryv (Lawrence Velázquez)
Seems weird to me to use your fork for this while still referring to the original homepage.
comment:4 follow-up: 5 Changed 12 years ago by cooljeanius (Eric Gallager)
Replying to larryv@…:
Seems weird to me to use your fork for this while still referring to the original homepage.
- My fork compiles on OS X; the original doesn't
- The original actually has a homepage; I haven't bothered making anything quite that fancy for my fork
Feel free to remove the homepage entry if you want...
comment:5 follow-up: 6 Changed 12 years ago by larryv (Lawrence Velázquez)
Is this something you’re going to actively maintain? How extensive are the changes you made? Would it be viable for the portfile to patch the original source directly?
comment:6 Changed 12 years ago by cooljeanius (Eric Gallager)
Replying to larryv@…:
Is this something you’re going to actively maintain?
Well I'm not planning on making any major functionality changes or anything like that to it, but I'll do my best to fix bug reports and stuff.
How extensive are the changes you made?
See comment:2 above.
Would it be viable for the portfile to patch the original source directly?
idk, I haven't tried that method.
Changed 12 years ago by cooljeanius (Eric Gallager)
diff between the original source tarball and my fork
comment:7 Changed 12 years ago by cooljeanius (Eric Gallager)
I opened an issue upstream to make sure they're okay with my portfile submission here: https://sourceforge.net/tracker/?func=detail&aid=3607509&group_id=49169&atid=455337
Although I'm not really expecting a response seeing as the original Sourceforge project is dead, so I wouldn't really wait to hear anything back before committing this...
comment:8 Changed 12 years ago by cooljeanius (Eric Gallager)
I found the configure script that I had originally seen the message about gaa scrolling by in: it was for gnutls (edit: the old version of gnutls, that is):
checking for gaa... no configure: WARNING: *** *** GAA was not found. It is only needed if you wish to modify *** the source code or command-line description files. In this case, *** you may want to get it from http://gaa.sourceforge.net/ and *** read doc/README.gaa. ***
comment:9 Changed 11 years ago by cooljeanius (Eric Gallager)
Apparently Fink already had a package for gaa that I could've been working from this whole time:
http://pdb.finkproject.org/pdb/package.php/gaa
Anyway I'm working on a new version of this portfile that patches the original source instead of using my fork...
comment:10 Changed 13 months ago by cooljeanius (Eric Gallager)
PR submitted on GitHub: https://github.com/macports/macports-ports/pull/20972
comment:11 Changed 13 months ago by cooljeanius (Eric Gallager)
Resolution: | → fixed |
---|---|
Status: | new → closed |
portfile for gaa