#38217 closed enhancement (fixed)
doxygen: Should not depend on graphviz
| Reported by: | larryv (Lawrence Velázquez) | Owned by: | cssdev |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | afb@…, andre.anjos@…, neverpanic (Clemens Lang), dbevans (David B. Evans), eborisch (Eric A. Borisch), jeremyhu (Jeremy Huddleston Sequoia), laurent.el-shafey@…, marin.saric@…, michaelld (Michael Dickens), n3npq@…, ryandesign (Ryan Carsten Schmidt), cooljeanius (Eric Gallager) | |
| Port: | doxygen awesome bob eigen3 fish gerbil gnome-vfsmm gnuradio goocanvasmm gr-osmosdr kdeaddons3 kdebase3 kdelibs3 libexif libgphoto2 libspectre ogre openni rpm rpm45 rpm50 rpm51 rpm52 rpm53 rpm54 sofia-sip xorg-libxcb |
Description
One does not require Graphviz to use Doxygen, so the doxygen port should not depend on graphviz. Ports that require Doxygen’s Graphviz integration should declare a separate dependency on graphviz. I will see if any ports need this.
https://lists.macosforge.org/pipermail/macports-dev/2013-February/022085.html https://lists.macosforge.org/pipermail/macports-dev/2013-February/022086.html https://lists.macosforge.org/pipermail/macports-dev/2013-February/022089.html https://lists.macosforge.org/pipermail/macports-dev/2013-February/022090.html https://lists.macosforge.org/pipermail/macports-dev/2013-February/022102.html
Attachments (2)
Change History (14)
comment:1 Changed 12 years ago by cooljeanius (Eric Gallager)
comment:2 Changed 12 years ago by jmroot (Joshua Root)
A default variant would mean that everyone gets graphviz pulled in unless they specifically know to disable the variant, which seems like it defeats the purpose of the change. Also, wouldn't the variant do nothing but add a dependency, and not change the installed files at all? That's not really what variants should be used for.
comment:3 Changed 12 years ago by larryv (Lawrence Velázquez)
| Cc: | afb@… andre.anjos@… cal@… devans@… eborisch@… jeremyhu@… laurent.el-shafey@… marin.saric@… michaelld@… n3npq@… ryandesign@… added |
|---|---|
| Port: | awesome bob eigen3 fish gerbil gnome-vfsmm gnuradio goocanvasmm gr-osmosdr kdeaddons3 kdebase3 kdelibs3 libexif libgphoto2 libspectre ogre openni rpm rpm45 rpm50 rpm51 rpm52 rpm53 rpm54 sofia-sip xorg-libxcb added |
As far as I can tell, these are the ports that use Graphviz (or can autodetect and use it) while generating Doxygen documentation. I’d like to add an explicit path:bin/dot:graphviz dependency to each one; please let me know if this is incorrect for any of them.
Changed 12 years ago by larryv (Lawrence Velázquez)
| Attachment: | graphviz-deps.diff added |
|---|
add explicit graphviz dependencies
Changed 12 years ago by larryv (Lawrence Velázquez)
| Attachment: | graphviz-deps.2.diff added |
|---|
add explicit graphviz dependencies
comment:4 Changed 12 years ago by larryv (Lawrence Velázquez)
Oops, accidentally uploaded the same diff twice.
comment:6 Changed 12 years ago by michaelld (Michael Dickens)
comment:7 Changed 12 years ago by larryv (Lawrence Velázquez)
I just committed the {no,open}maintainer ones: sofia-sip (r103760), libgphoto2 (r103761), gnome-vfsmm (r103762), goocanvasmm (r103763), libexif (r103764), awesome (r103765), fish (r103766), kdebase3 (r103767), kdeaddons3 (r103768), kdelibs3 (r103769), openni (r103770), libspectre (r103771), gerbil (r103772), xorg-libxcb (r103773).
comment:8 Changed 12 years ago by neverpanic (Clemens Lang)
Sorry, I didn't even realize one of my ports was affected. I don't care whether gerbil actually has graphs in its documentation and I wouldn't mind dropping the dependency there, too. Since you added it now, let's just keep it that way for now.
comment:9 Changed 12 years ago by andre.dos.anjos@…
A patch for the bob port has been submitted at (#38325). It addresses this request and an upgrade to version 1.1.3 at the same time.
comment:10 Changed 12 years ago by larryv (Lawrence Velázquez)
comment:11 Changed 12 years ago by larryv (Lawrence Velázquez)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Moved the graphviz dependency to doxygen’s +doc variant in r104112.
From the mailing lists:
^ I vote for that option.