#38304 closed defect (fixed)
i386-mingw32-binutils @2.21-3_0: windres converts resource string to UTF-16 with wrong endianness, PATCH
| Reported by: | tuffnatty (Phil Krylov) | Owned by: | landonf (Landon Fuller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | cooljeanius (Eric Gallager), mojca (Mojca Miklavec) |
| Port: | i386-mingw32-binutils |
Description
This is an old upstream bug: http://sourceware.org/bugzilla/show_bug.cgi?id=13409 The upstream maintainers are too slow, the patch is available for half a year already. The patch is attached.
Attachments (2)
Change History (15)
Changed 12 years ago by tuffnatty (Phil Krylov)
| Attachment: | Portfile-i386-mingw32-binutils.diff added |
|---|
Changed 12 years ago by tuffnatty (Phil Krylov)
| Attachment: | patch-binutils-winduni.c.diff added |
|---|
Source code patch
comment:2 Changed 12 years ago by larryv (Lawrence Velázquez)
| Cc: | phil.krylov@… removed |
|---|---|
| Keywords: | haspatch maintainer added; mingw32 windres binutils removed |
| Owner: | changed from macports-tickets@… to landonf@… |
| Port: | i386-mingw32-binutils added; i386-mingw32msvc-binutils removed |
| Summary: | i386-mingw32msvc-binutils @2.21.3_0 windres converts resource string to UTF-16 with wrong endianness, PATCH → i386-mingw32-binutils @2.21-3_0: windres converts resource string to UTF-16 with wrong endianness, PATCH |
Thanks for the ticket; in the future, please Cc relevant port maintainers. Also, as the ticket reporter, don’t have to Cc yourself.
comment:3 Changed 12 years ago by mf2k (Frank Schima)
| Keywords: | maintainer removed |
|---|
comment:4 follow-up: 5 Changed 12 years ago by tuffnatty (Phil Krylov)
Thank you; I forgot to fill in the Cc when creating the ticket, and after creation, I could only click "Cc Me", without any possibility to Cc the port maintainer. Should I file another ticket regarding this Trac issue?
comment:5 Changed 12 years ago by jmroot (Joshua Root)
Replying to phil.krylov@…:
Thank you; I forgot to fill in the Cc when creating the ticket, and after creation, I could only click "Cc Me", without any possibility to Cc the port maintainer. Should I file another ticket regarding this Trac issue?
Not in our Trac, but you could report it at http://trac.edgewall.org/ if you think the permissions model should be more flexible.
comment:7 Changed 8 years ago by mojca (Mojca Miklavec)
| Cc: | mojca added |
|---|
comment:8 Changed 8 years ago by mojca (Mojca Miklavec)
| Version: | 2.1.3 |
|---|
The ports seems to build fine on the buildbot at the moment.
See also:
I would be grateful for further feedback & whether or not this is still a problem.
Then again I would be in favour of removing this port, you can install i686-w64-mingw32-binutils now.
comment:9 Changed 8 years ago by tuffnatty (Phil Krylov)
1) This port did always build fine. The bug reported reveals itself on runtime of a program built using this binutils/windres version. 2) If mingw-w64-* work well finally, there is probably no need for mingw32. I am using a self-built port of mingw-w64 recently. 3) On the other hand, I see no reason to not accept the patch until all mingw32 users switch to mingw-w64, because it is in upstream, tested for ages already, and adding the patch to macports does not seem difficult.
comment:10 Changed 8 years ago by mojca (Mojca Miklavec)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:11 Changed 8 years ago by mojca (Mojca Miklavec)
I checked and the patch is already applied in the version of binutils used by i686-w64-mingw32-binutils as well as in the version of binutils as shipped by the MinGW project (2.25.1). I updated the port even (if it's going to be removed afterwards). I didn't bother modernizing it in any other way. I guess I could install it from binutils directly, but then again you would get exactly the same port as i686-w64-mingw32-binutils provides already, only using different names.
comment:12 Changed 8 years ago by mojca (Mojca Miklavec)
It fails to build on 10.6:
Undefined symbols:
"_wcsncasecmp", referenced from:
_rsrc_sort_entries in libbfd.a(peigen.o)
but I'm not going to worry why as the port from MinGW-w64 builds just fine.
Portfile patch