Opened 12 years ago

Closed 12 years ago

#38313 closed update (fixed)

ncdc 1.15 update

Reported by: ethernet.zero@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc:
Port: ncdc

Description

The attached patch updates the Portfile from ncdc 1.12 to 1.15.

Works fine on Mountain Lion.

Attachments (1)

Portfile-ncdc-1.15.diff (1.6 KB) - added by ethernet.zero@… 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by ethernet.zero@…

Attachment: Portfile-ncdc-1.15.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks!

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

To provide some commentary on your changes:

  • You removed the --enable-db-upgrade configure arg; the ChangeLog confirms that the legacy ncdc-db-upgrade utility that this configure arg built was removed in 1.14.
  • You removed the gdbm dependency; the ChangeLog doesn't mention this but examining my ncdc 1.12 installation I see gdbm was only used by the old ncdc-db-upgrade utility.
  • You removed the libxml2 dependency; the ChangeLog confirms libxml2 usage was dropped in 1.11 so we should have already removed this dependency.
  • You added the zlib dependency; the ChangeLog confirms this became required in 1.13. It had been there indirectly via libxml2 before.
  • You removed the block that prevented installation on Leopard and older; according to #31990 we added that because ncdc's use of realpath() required Snow Leopard or newer, and according to the ChangeLog they no longer use realpath() as of 1.13. I verified that 1.12 crashed on Leopard and 1.15 runs fine. Great!

Committed your patch in r103790.

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.