#38367 closed update (fixed)
Update py-nmrglue to version 0.4
| Reported by: | michelle.lynn.gill@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | py-nmrglue |
Description
I've provided an updated Portfile that handles the upgrade of the python port nmrglue from version 0.3 to 0.4.
Attachments (1)
Change History (8)
comment:1 follow-up: 2 Changed 12 years ago by mf2k (Frank Schima)
| Keywords: | haspatch maintainer added |
|---|---|
| Version: | 2.1.3 |
comment:2 Changed 12 years ago by michelle.lynn.gill@…
Replying to macsforever2000@…:
Also, why did you remove the rmd160 checksum and add the old, no longer preferred, md5 and sha1 checksums?
Because those are the checksums that are generated by MacPorts in the logfile. If different checksums are preferred, it might be a good idea to update what is put into the logfile by MacPorts.
comment:3 follow-up: 4 Changed 12 years ago by mf2k (Frank Schima)
Not true, it uses the same checksums that are in the Portfile.
comment:4 Changed 12 years ago by michelle.lynn.gill@…
Replying to macsforever2000@…:
Not true, it uses the same checksums that are in the Portfile.
Hmm, I wonder if it was using my own version of the Portfile which had the old checksums present.
I will upload a diff file with the preferred checksums and the python default version removed.
I assume there's a reason for not switching the checksums to the new version in the log file if the existing checksums fail, regardless of which version is present in the Portfile? That seems to be what is the desired behavior here.
Changed 12 years ago by michelle.lynn.gill@…
| Attachment: | Portfile.diff added |
|---|
Updates to checksums and python version removed
comment:5 Changed 12 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 12 years ago by mf2k (Frank Schima)
The checksum behavior makes sense as it stands. But post on the -dev list if you want to discuss it.
comment:7 Changed 12 years ago by jmroot (Joshua Root)
There's nothing wrong with sha1, and it's what upstream provides, so that's a good reason to use it.
The python.default_version line is not necessary because python 2.7 is the default. Also, why did you remove the rmd160 checksum and add the old, no longer preferred, md5 and sha1 checksums?