RFE: make the aclocal.m4 file in base safe to regenerate with `aclocal`

[cooljeanius (Eric Gallager)]

Regenerating aclocal.m4 with aclocal is a standard part of an autotools workflow. Automake tells you to do it, libtoolize tells you to do it, gettextize tells you to do it, and I'm sure there are other tools that tell you to do it, too, that I'm just not thinking of now. However, the aclocal.m4 file in base contains some hard-coded macros in it, meaning that if you run aclocal, you're going to overwrite them and then be missing some of the macros you need. This is pretty simple to fix: you could rename the current aclocal.m4 file to acinclude.m4, or move it into the m4/ directory in base, or both. After doing that, you can regenerate the aclocal.m4 file with aclocal -I m4.

[cooljeanius (Eric Gallager)]

Also I think I brought this up in IRC once...

[cooljeanius (Eric Gallager)]

Actually this is a little more complicated than that; some "underquoted macro" problems have to be fixed, too, for it to be safe to run aclocal. I'll attach a diff next. (After that the "haspatch" keyword can be added)

[cooljeanius (Eric Gallager)]

patch to apply to the base directory

[cooljeanius (Eric Gallager)]

Hm, it doesn't seem to include what the actual contents of acinclude.m4 are, it just says that it's "Only in ./m4"... guess I should attach a separate diff for that one...

[cooljeanius (Eric Gallager)]

patch to apply to aclocal.m4 after moving it to m4/acinclude.m4

[cooljeanius (Eric Gallager)]

This can be marked with the keyword "haspatch"

[cooljeanius (Eric Gallager)]

I opened PR 342 to fix this: ​https://github.com/macports/macports-base/pull/342