boswars did not compile

[mschaaf@…]

:debug:main org.macports.load registered provides 'load', a pre-existing procedure. Target override will not be provided
:debug:main org.macports.unload registered provides 'unload', a pre-existing procedure. Target override will not be provided
:debug:main org.macports.distfiles registered provides 'distfiles', a pre-existing procedure. Target override will not be provided
:debug:main Using group file /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/_resources/port1.0/group/select-1.0.tcl
:debug:main Reading variant descriptions from /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/_resources/port1.0/variant_descriptions.conf
<r/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_games_boswars/boswars/main.log" [readonly] 611L, 49969C
:info:build engine/video/png.cpp:239: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:285: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:286: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:287: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:288: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:289: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp:290: error: invalid use of incomplete type 'struct png_info_def'
:info:build /opt/local/include/png.h:733: error: forward declaration of 'struct png_info_def'
:info:build engine/video/png.cpp: In function 'void SaveScreenshotPNG(const std::string&)':
:info:build engine/video/png.cpp:343: error: invalid use of incomplete type 'struct png_struct_def'
:info:build /opt/local/include/png.h:860: error: forward declaration of 'struct png_struct_def'
:info:build scons: *** [build/debug/video/png.o] Error 1
:info:build scons: building terminated because of errors.
:info:build Command failed: /opt/local/bin/scons debug
:info:build Exit code: 2
:error:build org.macports.build for port boswars returned: command execution failed
:debug:build Error code: NONE
:debug:build Backtrace: command execution failed
    while executing
"$procedure $targetname"
:info:build Warning: targets not executed for boswars: org.macports.activate org.macports.build org.macports.destroot org.macports.install
:notice:build Please see the log file for port boswars for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_games_boswars/boswars/main.log

[larryv (Lawrence Velázquez)]

Please run the following and attach (do not paste) the entire main.log file mentioned in the failure message.

sudo port clean boswars
sudo port install boswars

[ryandesign (Ryan Carsten Schmidt)]

Probably an incompatibility with libpng 1.5 that we'll have to patch.

[ryandesign (Ryan Carsten Schmidt)]

boswars 2.6.1 has been available for years; we should try to update the port to this version; perhaps it already includes the necessary libpng 1.5 rewrites. I did try to update the port to this version some time ago; I don't remember if I ran into problems.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

boswars 2.6.1 has been available for years; we should try to update the port to this version; perhaps it already includes the necessary libpng 1.5 rewrites.

It does. Updated in r104820.

I did try to update the port to this version some time ago; I don't remember if I ran into problems.

I think I saw other stylistic issues with the port that I wanted to fix, then didn't complete. These remain to be addressed.