update to mosh-1.2.4

[ryandesign (Ryan Carsten Schmidt)]

Should we really change the master_sites? The 1.2.4 file seems to be available at the old URL. And the ​github uploads feature is deprecated and going away.

[tpyro@…]

I can see ​1.2.3 at the old URL but not ​1.2.4. The address provided in the diff was from this ​mailing list announcement. Posted by a user just trying to make it work; no further meaning intended.

[jmroot (Joshua Root)]

Your diff is reversed, which probably accounts for Ryan's confusion. BTW, we really prefer unified diffs (use diff -u).

[quentinmit (Quentin Smith)]

There's also a dependency change needed for mosh 1.2.4. I think we can drop port:p5.12-io-tty from depends_lib.

I'll try to make a suitable patch in the next day or two.

[neverpanic (Clemens Lang)]

I've attached a patch that does that and also fixes livecheck. If the patch looks good to you, I will commit it.

[quentinmit (Quentin Smith)]

The only thing I noticed is that it still has the post-patch section to patch the script to use MacPorts' perl, but now there's no dependency tree that pulls in Perl. I'm not sure what the MacPorts standard is - either we can add a dependency on Perl, or remove the post-patch section and use the system perl. Do you know what packages usually do for that?

[neverpanic (Clemens Lang)]

Replying to quentin@…:

The only thing I noticed is that it still has the post-patch section to patch the script to use MacPorts' perl, but now there's no dependency tree that pulls in Perl. I'm not sure what the MacPorts standard is - either we can add a dependency on Perl, or remove the post-patch section and use the system perl. Do you know what packages usually do for that?

How does mosh use perl? Only for building, or also at runtime? The standard approach usually is to use MacPorts perl, but if we know this will work fine on all system perls and some other part of mosh's dependency tree isn't pulling it in anyway, we might consider dropping it.

[quentinmit (Quentin Smith)]

It uses it at runtime. ($prefix/bin/mosh is a small Perl script that invokes ssh and mosh-client.)

It's probably more convenient to use MacPorts's perl, so we don't have to test on ancient perl versions, but I'd hate for mosh to be the only reason someone pulled in MacPorts perl. I'm fine with whichever approach you want to go with.

[neverpanic (Clemens Lang)]

Replying to quentin@…:

It uses it at runtime. ($prefix/bin/mosh is a small Perl script that invokes ssh and mosh-client.)

OK, I'll take a look at the script as soon as my Mac finished maintenance and will decide then.

It's probably more convenient to use MacPorts's perl, so we don't have to test on ancient perl versions, but I'd hate for mosh to be the only reason someone pulled in MacPorts perl.

That's unlikely because it is very likely _every_ MacPorts user has perl installed nowadays. It's also not as critical, because users no longer have to actually compile perl, but will get a pre-compiled package from our buildbots (the same goes for mosh, btw).

[neverpanic (Clemens Lang)]

mosh needs Getopt::Long in line 38 of $prefix/bin/mosh. I've added a dependency on p5.12-getopt-long (which also answers the question whether we will use MacPorts' perl or not). Commited the update in r105213.

[quentinmit (Quentin Smith)]

Getopt::Long is a core module (meaning it's distributed with perl); I don't think that actually answers the question.

(Why does MacPorts have a separate package for a core module, anyway? To get a newer version?)