Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#38708 closed enhancement (fixed)

py-astropy: use external, MacPorts cfitsio, expat, and wcslib; drop redundant python.default_version

Reported by: lpsinger (Leo Singer) Owned by: robitaille@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: py-astropy

Description

The attached patch makes two changes to py-astropy.

First, it makes Astropy build against external versions of cfitsio, expat, and wcslib, and depend on those ports. Astropy comes with bundled sources for each of these, but the appropriate build arguments tell it to reuse preinstalled versions of these packages. Astropy also depends on sofa, but there is no MacPorts package for sofa.

Second, it removes a redundant setting of python.default_version; Python 2.7 is already the default.

Attachments (1)

patch-Portfile.diff (950 bytes) - added by lpsinger (Leo Singer) 12 years ago.
proposed patch for py-astropy Portfile

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by lpsinger (Leo Singer)

Attachment: patch-Portfile.diff added

proposed patch for py-astropy Portfile

comment:1 Changed 12 years ago by jmroot (Joshua Root)

Cc: robitaille@… removed
Owner: changed from macports-tickets@… to robitaille@…
Version: 2.1.3

As a committer you should be able to assign tickets to the maintainer rather than just Ccing them.

comment:2 Changed 12 years ago by lpsinger (Leo Singer)

Mind if I go ahead and commit this?

comment:3 Changed 12 years ago by lpsinger (Leo Singer)

Resolution: fixed
Status: newclosed

Fixed in r105488 after maintianer timeout.

comment:4 Changed 12 years ago by robitaille@…

Sorry for not checking this sooner - It looks like this has caused buildbot failures, did you receive those @aronnax?

comment:5 Changed 12 years ago by lpsinger (Leo Singer)

Yes, I noticed the build failures. The problem was a missing build dependency on pkgconfig, fixed in r105490. I didn't notice the dependency on pkgconfig because I only did test builds on my own machine, which already had pkgconfig.

Sorry about that. I should have tested it more thoroughly, and I probably should have alerted you of the buildbot failures and the cause, rather than committing r105490 straightaway.

comment:6 Changed 12 years ago by robitaille@…

No worries, thanks for the patch and for fixing the failures!

Note: See TracTickets for help on using tickets.