port submission: xrmc

[Tom.Schoonjans@…]

xrmc is a tool for the simulation of X-ray imaging and spectroscopy experiments using the Monte Carlo method.

With this port file, this package could be added to MacPorts.

Thank you for your consideration

[cooljeanius (Eric Gallager)]

Could the dependency on gcc47 be changed into compiler variants?

[Tom.Schoonjans@…]

Replying to egall@…:

Could the dependency on gcc47 be changed into compiler variants?

Hmmm... not really. The problem is that the package requires g++ with OpenMP v3.0+ support. This rules out the clang++ and g++ compilers that are shipped with Xcode.

I could provide variant support for gcc44, gcc45, gcc46 if necessary though if you consider it useful. These compilers also have the required openmp support.

[ryandesign (Ryan Carsten Schmidt)]

Replying to Tom.Schoonjans@…:

I could provide variant support for gcc44, gcc45, gcc46 if necessary though if you consider it useful. These compilers also have the required openmp support.

That's what Eric was suggesting. See wiki:PortfileRecipes#gcc

[ryandesign (Ryan Carsten Schmidt)]

Also, since the software is on github, consider using the github portgroup.

And if possible, please indicate which version(s) of the GPL are acceptable; not listing a version number implies that any version is acceptable, but it's rare these days to find GPL software that allows GPL version 1 (other than perl-based software which still does).

[mf2k (Frank Schima)]

for gcc versions it would be better to use gcc45 through gcc48.

[Tom.Schoonjans@…]

Ok, I've added the gcc45 trough gcc48 variants to the file.

I didn't add the PortGroups github though: if I understand correctly this would automatically set the master_sites location to tarballs generated by github, which is not what I want to happen.

[Tom.Schoonjans@…]

Hello,

Could you give the new Portfile I added a closer look?

Thanks,

Tom

[ryandesign (Ryan Carsten Schmidt)]

We should not use "then" in the "if" statement. "then" is optional in Tcl "if" statements, and I'm not aware of anywhere else in MacPorts where we use it, so for consistency I'd like to not use it here either.

Yes, the github portgroup sets defaults for master_sites, among other things. You're of course free to override that as needed. My hope had been that by using the github portgroup you would get a working livecheck for free, however I see now that's not the case, because the developers unfortunately have not created any tags in their repository, so we'll need to fix the livecheck manually. The github portgroup doesn't seem to provide any benefit right at this time, but I'll add it anyway, since it will make it easier to update the port in the event that github makes global changes in their infrastructure, which they have done before.

Since the project's github main page contains no information whatsoever, I've changed the homepage to the github wiki page.

The license field is not formatted properly; it should be "GPL-3" not "GPLv3". If later versions of the license are also accepted (which based on the comments in the source code files seems to be the case), then it should be "GPL-3+".

The checksums do not match. The portfile was attached April 11 and the distfile was last modified April 23. Perhaps the developers performed a stealth update. I hope they are not in the habit of doing that.

I can't check to see if the port builds because its dependency xraylib does not build (#39263). I'm attaching my revised portfile.

[Tom.Schoonjans@…]

Hello again,

Sorry about the stealth update: that one's on me and was pretty stupid. Won't happen again.

Thanks for making the necessary changes to the Portfile. I agree completely with its current contents.

One remark though about the Tcl then statement: I just copy pasted here from the PortfileRecipes as was recommended to me earlier. You may want to change it there as well then.

The xraylib build problem is due to a bug in python2.7, as I've mentioned in #39263. As soon as they fix that one, you may want to try rebuilding xraylib and xrmc.

Best,

Tom

[ryandesign (Ryan Carsten Schmidt)]

Replying to Tom.Schoonjans@…:

One remark though about the Tcl then statement: I just copy pasted here from the PortfileRecipes as was recommended to me earlier. You may want to change it there as well then.

Thanks, looks like that was recently changed. I changed it back.

[cooljeanius (Eric Gallager)]

Cc Me!

[Tom.Schoonjans@…]

Could you please give it another shot? I fixed the xraylib bug quite some time ago...

Thanks in advance,

Tom

[Tom.Schoonjans@…]

Hi,

Could you give the portfile another look? As far as I know, everything should work now...

Thanks,

Tom

[mf2k (Frank Schima)]

comment deleted.

[mf2k (Frank Schima)]

Cc Me!

[Tom.Schoonjans@…]

Portfile for version 6.4.3

[Tom.Schoonjans@…]

This last version refers to version 6.4.3 of xrmc, which was released two weeks ago. It depends on version 3.0.0 of xraylib that was yesterday updated on Macports.

As far as I know it builds and works like a charm...

Please consider adding this port to Macports

[pixilla (Bradley Giesbrecht)]

ryandesign: Portfile.4 builds for me. Would you like me to commit it?

[mf2k (Frank Schima)]

This should now be updated to use the compilers 1.0 portgroup.

[Tom.Schoonjans@…]

Thanks for proceeding with the submission. Feel free to modify the file as you see fit.

In the meantime we already released version 6.4.4 by the way.

rmd160 9213af0f472c32efc1ed53044c77d67971167f27

sha256 c42c624ea00fd24466e7d1ed559814cdea7c2a2ac7fab40bf73237821960a4be

[ryandesign (Ryan Carsten Schmidt)]

Committing updated version based on duplicate #45764 in r127832.