e_dbus @1.7.6 needs a dependency on valgrind

[cooljeanius (Eric Gallager)]

Doing a rev-upgrade failed to repair my broken e_dbus during configuring with the following message:

checking for pkg-config... /opt/local/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking whether to build documentation... yes
checking for doxygen... yes
checking for DBUS... yes
checking for EDBUS... no
configure: error: Package requirements (ecore >= 1.7.6 eina >= 1.7.6 dbus-1 >= 0.62) were not met:

Package 'valgrind', required by 'eina', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables EDBUS_CFLAGS
and EDBUS_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_e_dbus/e_dbus/work/e_dbus-1.7.6" && ./configure --prefix=/opt/local --disable-dependency-tracking --disable-silent-rules 

Also, even though eina is supposed to get dragged in as a recursive dependency of ecore (via eet), maybe e_dbus needs an explicit dependency on it, as well.

[cooljeanius (Eric Gallager)]

Actually it would probably be better to specify the dependency as:

path:lib/pkgconfig/valgrind.pc:valgrind

so that valgrind-devel could satisfy it, too.

[maehne (Torsten Maehne)]

Cc Me!

[cooljeanius (Eric Gallager)]

could this get another look now that r113013 has updated the enlightenment ports?

[ryandesign (Ryan Carsten Schmidt)]

I am not able to reproduce the failure reported in this ticket. These 8 related ports build fine on my systems, without valgrind installed. Please attach a main.log and config.log if you'd like me to investigate.

[cooljeanius (Eric Gallager)]

Actually nvm, the recent upgrade seems to have made this not happen any more...

[ryandesign (Ryan Carsten Schmidt)]

Ok great.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

These 8 related ports build fine on my systems, without valgrind installed.

These ports and others are being combined into EFL, the Enlightenment Foundation Libraries. The EFL 1.8.0-alpha1 README explains what's going on with valgrind:

VALGRIND DEPENDENCY:
------------------------------------------------------------------------------
EFL uses the concept of memory pools (mempool) and this will confuse
valgrind memcheck tool. By using memory pool, the memory is still
owned by EFL, then valgrind won't alert on memory leaks or use of
unused memory. EFL will use memcheck.h from valgrind to declare its
memory pools to valgrind, producing better debugging results.

However valgrind is only available to limited platforms, making us
hard to declare it a mandatory requirement. Based on
--with-profile={dev,debug} valgrind will be used if available or will
be issued a warning. You can force valgrind with --enable-valgrind, or
disable it and the warning with --disable-valgrind.

EFL does NOT link to valgrind libraries. Then there is NO runtime
dependency on valgrind.

So while that's nice, valgrind is indeed only available to limited platforms—last I checked it would only install on Snow Leopard and Lion, not earlier versions, not later versions—so we should not make valgrind a dependency nor use it opportunistically. I've explicitly disabled valgrind support in eina and evas in r115054.