Opened 11 years ago

Closed 11 years ago

#39222 closed update (fixed)

Upgrade PDL to 2.006 and adds ports for some prereqs

Reported by: mgrimes@… Owned by: tim@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mf2k (Frank Schima)
Port: p5-pdl

Description

The PDL team as request someone help upgrade and maintain the p5-pdl port:

http://mailman.jach.hawaii.edu/pipermail/perldl/2013-May/007906.html

I have volunteered and updated the Portfile, as well as, ports for the missing prerequisites. I believe the current maintainer (saao.ac.za:tim) is looking to turn over maintenance to someone else. I am willing to step up for the time being, but don't want to push Tim (or anyone else) out if they are interested.

The attached patches provides the following:

  • Patches p5-pdl/Portfile and adds a script to files to fix the documentation database
  • Adds ports for p5-file-map, p5-module-compile, p5-convert-uu and p5-perlio-layers, which are prereqs for p5-pdl
  • Adds port for p5-pdl-graphics-gnuplut, which isn't a prerequisite, but helpful for demos, etc.

Thanks, Mark

Attachments (7)

p5-pdl.patch (6.2 KB) - added by mgrimes@… 11 years ago.
p5-pdl-prereqs.patch (4.1 KB) - added by mgrimes@… 11 years ago.
p5-pdl-graphics-gnuplot.patch (1.1 KB) - added by mgrimes@… 11 years ago.
p5-pdl.2.patch (6.2 KB) - added by mgrimes@… 11 years ago.
p5-pdl-prereqs.2.patch (3.7 KB) - added by mgrimes@… 11 years ago.
p5-pdl-graphics-gnuplot.2.patch (1.0 KB) - added by mgrimes@… 11 years ago.
p5-pdl-and-prereqs.diff (11.0 KB) - added by mvgrimes 11 years ago.
Patch from 2.4 to 2.6 including new ports for prereqs and pdl-graphics-gnuplot

Download all attachments as: .zip

Change History (24)

Changed 11 years ago by mgrimes@…

Attachment: p5-pdl.patch added

Changed 11 years ago by mgrimes@…

Attachment: p5-pdl-prereqs.patch added

Changed 11 years ago by mgrimes@…

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… added; saao.ac.za:tim tim@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to tim@…
Version: 2.1.3

Trac accepts normally formatted email addresses only.

@tim: Please let us know if you still are maintaining this port.

comment:2 Changed 11 years ago by mf2k (Frank Schima)

@mgrimes: Thanks for your contribution, but your new ports really need to be cleaned up a bit. The output of cpan2port is just a start.

  • Are they in fact noarch? Please check each one and uncomment or delete the line as appropriate.
  • The license field for each new port should be added. Often the same license as the perl5.16 port will work if it uses the "perl 5" license.
Last edited 11 years ago by mf2k (Frank Schima) (previous) (diff)

comment:3 in reply to:  2 Changed 11 years ago by mgrimes@…

Thanks for the pointers. I've added or removed the noarch flag as appropriate, set the license and wrapped the depends in if {${perl5.major} != ""}. Hope these look better.

I'm not sure what to do for maintainer, particularly for p5-pdl.

I think most of the other usual lines are generated by PortGroup (homepage, platforms, etc). Please let me know if I missed any others.

Changed 11 years ago by mgrimes@…

Attachment: p5-pdl.2.patch added

Changed 11 years ago by mgrimes@…

Attachment: p5-pdl-prereqs.2.patch added

Changed 11 years ago by mgrimes@…

comment:4 Changed 11 years ago by mf2k (Frank Schima)

Thanks, these look much better. Now we just need to wait for the maintainer's approval. Otherwise I will commit these in 3 days after maintainer timeout.

comment:5 Changed 11 years ago by mvgrimes

It doesn't look like these were ever committed. Anything I can do to move things along.

Also, there is a new version of PDL out (2.007). If/when I update the port to that version, should I submit it in the same fashion (ie, via trac)?

Thanks.

comment:6 Changed 11 years ago by mf2k (Frank Schima)

I just took a look at these again. I fixed a problem that the patch is no longer against the current svn revision. But I am not able to install p5.16-pdl because the port p5.16-convert-uu cannot be found.

$ sudo port install p5.16-pdl
Password:
--->  Computing dependencies for p5.16-pdl
Error: Dependency 'p5.16-convert-uu' not found.

comment:7 Changed 11 years ago by mf2k (Frank Schima)

If you want, you could attach an updated patch for the 2.007 version against the current svn revision of the p5-pdl port.

comment:8 Changed 11 years ago by mvgrimes

The p5-pdl-prereqs.2.patch attachement has Portfiles for all the missing prereqs (p5-convert-uu, p5-file-map, p5-module-compile, p5-perlio-layers). The p5-pdl-graphics-gnuplot.2.patch also creates a new port, but it isn't a prereq for p5-pdl. All in all, there are three .patch files that update p5-pdl and create five new ports.

comment:9 Changed 11 years ago by mf2k (Frank Schima)

Doh. Thanks for the pointer. But now I'm stuck on p5.16-file-map.

DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_opt_mports_trunk_dports_perl_p5-file-map/p5.16-file-map/work/File-Map-0.61" && /opt/local/bin/perl5.16 Makefile.PL INSTALLDIRS=vendor CC="/usr/bin/clang" LD="/usr/bin/clang"'
DEBUG: Executing command line:  cd "/opt/local/var/macports/build/_opt_mports_trunk_dports_perl_p5-file-map/p5.16-file-map/work/File-Map-0.61" && /opt/local/bin/perl5.16 Makefile.PL INSTALLDIRS=vendor CC="/usr/bin/clang" LD="/usr/bin/clang" 
Can't open perl script "Makefile.PL": No such file or directory
Command failed:  cd "/opt/local/var/macports/build/_opt_mports_trunk_dports_perl_p5-file-map/p5.16-file-map/work/File-Map-0.61" && /opt/local/bin/perl5.16 Makefile.PL INSTALLDIRS=vendor CC="/usr/bin/clang" LD="/usr/bin/clang" 

Indeed, the build directory has Build.PL but no Makefile.PL. I even tried with the latest version 0.61. Can you post a working Portfile for p5-file-map?

Changed 11 years ago by mvgrimes

Attachment: p5-pdl-and-prereqs.diff added

Patch from 2.4 to 2.6 including new ports for prereqs and pdl-graphics-gnuplot

comment:10 Changed 11 years ago by mvgrimes

I'm not sure why that is failing. The Portfile that I have for p5-file-map includes:

perl5.use_module_build

On my system it uses Build.PL in the build step and works fine. Maybe there is an issue with the patch file. I'm attaching a new diff (p5-pdl-and-prereqs.diff​) that includes p5-pdl, its prereqs and p5-pdl-graphics-gnuplot.

Thanks for tackling this.

comment:11 Changed 11 years ago by mf2k (Frank Schima)

Added p5-convert-uu in r112378.

comment:12 Changed 11 years ago by mf2k (Frank Schima)

Added p5-perlio-layers in r112380.

Last edited 11 years ago by mf2k (Frank Schima) (previous) (diff)

comment:13 Changed 11 years ago by mf2k (Frank Schima)

Added p5-file-map in r112381.

comment:14 Changed 11 years ago by mf2k (Frank Schima)

Added p5-module-compile in r112382.

comment:15 Changed 11 years ago by mf2k (Frank Schima)

Updated p5-pdl in r112383.

comment:16 Changed 11 years ago by mf2k (Frank Schima)

Added p5-pdl-graphics-gnuplot in r112386.

comment:17 Changed 11 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.