Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#39315 closed update (fixed)

subversion: update to 1.7.10, new bash-completion default dir and fix livecheck

Reported by: robsonpeixoto@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: danielluke (Daniel J. Luke), blair (Blair Zajac), raimue (Rainer Müller)
Port: subversion subversion-javahlbindings subversion-perlbindings subversion-python24bindings subversion-python25bindings subversion-python26bindings subversion-python27bindings subversion-rubybindings

Description

Fix the livecheck Put the bash-completion on new default bash-completion dir

Change History (20)

Changed 11 years ago by robsonpeixoto@…

comment:1 Changed 11 years ago by danielluke (Daniel J. Luke)

sorry, just saw this after committing 1.7.10 version bump in r106629 (which I had ready after the announcement, and was waiting for the test suites to complete + some time to look at it).

Can you point me to where/when the bash completion directory changed?

Thanks.

comment:2 Changed 11 years ago by robsonpeixoto@…

From: http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=blob;f=CHANGES;h=a4e8bcf80feaccd97e9bd0910b4dc0a7a06c152a;hb=HEAD

  • Layout change: everything is now in /usr/share/bash-completion/, rather than in /etc/.

comment:3 Changed 11 years ago by danielluke (Daniel J. Luke)

so, version 1.9? and macports updated to 2.0 in r95135? (11 months ago). Has it been broken since then?

comment:4 Changed 11 years ago by robsonpeixoto@…

They kept retrocompatibility with the old style.

comment:5 Changed 11 years ago by mf2k (Frank Schima)

Port: removed

comment:6 Changed 11 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: newclosed

livecheck updated in r106652 moved bash completion files in revision 1 of 1.7.0 of subversion (r106653).

Thanks for the ticket and the patches!

comment:7 Changed 11 years ago by robsonpeixoto@…

Thank you

comment:8 Changed 11 years ago by raimue (Rainer Müller)

Actually, this patch broke the bash-completion for svn as was reported to me today. Although there is a new directory, it also requires a new format of only one tool per file. For the new dynamic scheme, the completion file needs to be named exactly like the tool and is then loaded dynamically as soon as required.

This subversion completion file contains completions for multiple tools and would need to be split up. For now it's probably easier to just leave it in the ${prefix}/etc/bash_completion.d/ directory which still expects this old style. I tracked the change down to this ticket, but I can also open a new ticket if you want?

comment:9 Changed 11 years ago by raimue (Rainer Müller)

Cc: raimue@… added

Cc Me!

comment:10 in reply to:  8 Changed 11 years ago by danielluke (Daniel J. Luke)

Replying to raimue@…:

Actually, this patch broke the bash-completion for svn as was reported to me today. Although there is a new directory, it also requires a new format of only one tool per file. For the new dynamic scheme, the completion file needs to be named exactly like the tool and is then loaded dynamically as soon as required.

This subversion completion file contains completions for multiple tools and would need to be split up. For now it's probably easier to just leave it in the ${prefix}/etc/bash_completion.d/ directory which still expects this old style. I tracked the change down to this ticket, but I can also open a new ticket if you want?

You have my permission to commit a revert and revbump of this if you want (since you maybe actually use the bash-completion stuff and I don't). Let me know otherwise and I'll try to take care of it tomorrow.

comment:11 Changed 11 years ago by danielluke (Daniel J. Luke)

bash_completion change reverted in r111379

comment:12 Changed 11 years ago by raimue (Rainer Müller)

Thanks, I did not get to it earlier than you. After the upgrade, bash completion works again for svn and the other tools.

Note: See TracTickets for help on using tickets.