New portfile for ITSOL: ITerative linear SOLvers

[kingcrimson@…]

There is an ongoing GSoC project to integrate ITSOL in Octave So this library will soon become a dependence for octave and octave-devel.

This is my first attempt at creating a portfile so please bear with me if it is not perfect.

[michaelld (Michael Dickens)]

Cc Me!

[cooljeanius (Eric Gallager)]

1. It's revision, not reversion. This error prevents portindex from parsing the portfile.
2. After fixing 1., port -v lint --nitpick reports the following problems:

   eric-gallagers-macbook-pro:itsol root# port -v lint --nitpick
   --->  Verifying Portfile for itsol
   ...
   Warning: Line 5 should be a newline (after PortSystem)
   Warning: Line 42 has trailing whitespace before newline
   Warning: Line 50 has trailing whitespace before newline
   Warning: Line 62 has trailing whitespace before newline
   ...
   Error: Port revision is not numeric: 0.0.1
   ...
   --->  1 errors and 4 warnings found.
   

[cooljeanius (Eric Gallager)]

Cc Me!

[kingcrimson@…]

Replying to egall@…:

1. It's revision, not reversion. This error prevents portindex from parsing the portfile.
2. After fixing 1., port -v lint --nitpick reports the following problems:

   eric-gallagers-macbook-pro:itsol root# port -v lint --nitpick
   --->  Verifying Portfile for itsol
   ...
   Warning: Line 5 should be a newline (after PortSystem)
   Warning: Line 42 has trailing whitespace before newline
   Warning: Line 50 has trailing whitespace before newline
   Warning: Line 62 has trailing whitespace before newline
   ...
   Error: Port revision is not numeric: 0.0.1
   ...
   --->  1 errors and 4 warnings found.
   

Hi, I did fix these issues quite a while ago. Probably nobody noticed as I didn't add a comment ;) c.

[kingcrimson@…]

itsol-2.0.0 portfile

[kingcrimson@…]

I uploaded a new version to fix an issue with installation permissions c.

[kingcrimson@…]

It seems a new Octave release is going to happen soon, and this port is going to be a prerequisite.

Is there any specific reason why this port is being held back? Any specific changes needed to get it accepted?

c.

[michaelld (Michael Dickens)]

Any reason: Too much to do in my queue; too little time! I'll take a look and see what comes of it.

[michaelld (Michael Dickens)]

I see that the fortran compiler is being required/used. Do you know if the fortran code will work with g95, or does it require a newer gfortran? My hope would be to use the ​fortran recipe slightly modified. I'll try to get to this in the next couple of day, but feel free to ping this ticket if nothing happens for a while. I have plenty on my queue.

[kingcrimson@…]

Thanks for looking into this!

I only ever tried with gfortran 4.7 and 4.8, but ITSOL only uses very standard fortran 77 so I guess it should work OK with g95. On the other hand I never managed to build recent Octave versions with g95, so I don't see much use in a g95 ITSOL variant ...

[michaelld (Michael Dickens)]

I'm getting closer to having this port working; hopefully tomorrow. It's really not designed to build on OSX nor play nicely with MacPorts; it's not too difficult to coerce it into doing so (and, your help was a good starting point). That said, there are parts of this code which aren't really ready for prime time -- multiple definitions of a specific function in different files (e.g., lofC, add2is, add2com, indsetC, weightsC); maybe some of these are supposed to be static? The reason I'm getting these issues is because I'm creating a shared library version, which has more strict requirements than a static library. I haven't even gotten to the point of trying tests, and I certainly will do those to make sure these libraries work.

In order to do a shared library, I have to add +atlas and +accelerate, much like with octave; which is just fine, since if the new octave uses this project then they will have similar requirements. +g95 works just fine, btw, at least for me.

[michaelld (Michael Dickens)]

Done in r112010. The project should fix a bunch of issues; my patches do the basics, but I'm not 100% sure I'm doing them correctly. I'm closing this ticket; if there are issues with itsol, please open a new ticket to address them.

[kingcrimson@…]

Replying to michaelld@…:

Done in r112010. The project should fix a bunch of issues; my patches do the basics, but I'm not 100% sure I'm doing them correctly. I'm closing this ticket; if there are issues with itsol, please open a new ticket to address them.

cool, thanks! I'll try building Octave linking to this library and report back.