xyzsh @1.4.3

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• The standard modeline should be added, and the stray tab character should be converted to spaces.
• Listing just an md5 checksum is deprecated. Please list at least two checksums per file, preferably rmd160 and sha256.
• The port built just fine for me without libc-headers and libm-headers, and listing them as dependencies is problematic because libc-headers doesn't have a universal variant, which prevents xyzsh's universal variant from working. What's the reason for these dependencies?
• --prefix=/opt/local should be removed from configure.args. MacPorts might be installed in a different prefix. MacPorts already adds the correct prefix in configure.pre_args for you.
• If possible, the port should always build a static library and dynamic library; there should be no +static variant. However, trying to build the port with the +static variant results in the error "make: *** No rule to make target 'all'. Stop."
• Instead of using install_name_tool to fix the library reference in the program after the fact, the install_name of the library itself needs to be set correctly at build time.
• The livecheck doesn't work.

[ryandesign (Ryan Carsten Schmidt)]

Also, the files installed by xyzsh link with the ncurses and oniguruma5 libraries, so they're need to be in depends_lib not depends_build.

[rino@…]

Revised version of Portfile on Jun 9.

[rino@…]

Thank you very much for your kindly suggestion. I hope everything is fine with this Portfile.

• The standard modeline is added.
• List rmd160 and sha256 for checksum.
• Adding libc- and libm-headers as dependencies was my mistake. They are removed.
• --prefix and +static variant are removed.
• Changed to specify install_name at build time...however, I'm not sure this is the right way.
• The livecheck is added.
• Changed from depends_build to depends_lib.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[kurthindenburg (Kurt Hindenburg)]

I wasn't aware +static could be used - it doesn't error out but doesn't appear to do anything here.

Rino, if you want to update this to 1.5.8, I'll commit it for you.