Request: py27-ode

[glen@…]

The Open Dynamics Engine ships with python bindings. The bindings for ODE 0.12 support up to python27, but MacPorts only has up to p26-ode. Humbly requesting support for python27.

[glen@…]

That should of course be "MacPorts only has up to py26-ode."

[larryv (Lawrence Velázquez)]

The py2*-ode ports should probably use the unified Python portgroup.

[glen@…]

Replying to larryv@…:

The py2*-ode ports should probably use the unified Python portgroup.

Pardon my ignorance; what's the unified Python portgroup?

[larryv (Lawrence Velázquez)]

Replying to glen@…:

Pardon my ignorance; what's the unified Python portgroup?

Oh, that comment is for the maintainer, or whoever ends up tackling this. They should combine the separate py*-ode portfiles into a single py-ode portfile that provides subports for all Python versions. See distribute, for example.

[mf2k (Frank Schima)]

Replying to larryv@…:

The py2*-ode ports should probably use the unified Python portgroup.

Yes, just remove the word "probably".

[petrrr]

Cc Me!

[glen@…]

Any progress on this? Lack of python27 support is getting to be a drag...

[petrrr]

Okay, this might be a maintainer timeout, so I provides some patch here. Please review and comment or commit.

The port was already moved to the unified Python portgroup some time ago (probably after this ticket was filed), so there is actually very little work here.

I made some further changes along the way:

• some reformatting (non-semantic, in separate patch);

• added categories-append and license;
• long_description appended;
• delete unnecessary use_bzip2 and replace checksums;
• added requested version;

[petrrr]

non-semantic reformating

[petrrr]

semantic changes, updated

[petrrr]

for convenience the new Portfile, updated

[petrrr]

I updated the second patchfile and the final Portfile. The changes are:

• some correction to license;
• bump the version to 1.2.1 (which seems to be available only on PyPi);
• as a consequence master_sites and checksums change as well;

[mf2k (Frank Schima)]

Your patch file patch.Portfile.diff.2 does not apply for me. I'll try to manually add your changes.

[petrrr]

Is it because of the file naming? I it helps, I can provide a different copy.

[mojca (Mojca Miklavec)]

I committed r113372.

[mojca (Mojca Miklavec)]

Right, patch.Portfile.diff.2 didn't apply cleanly, probably because Peter tried to highlight the differences only, but the base port lacked "whitespace correction" first.

Even after using the patch, this wasn't sufficient because port patch would fail to apply the patch. I also fixed the patch then.

I changed Portfile to the extent that kept the contents, but made as little number of differences compared to the previous version as possible. If you now want to add some "fancy spacing" or "more reasonable order of variables" (platform before license and alike), feel free to prepare a new file by changing what's currently in SVN.

I always wondered if there was any "suggested order of variables".

(I first committed r113369 and then r113372.)

[petrrr]

Yes, sorry if I did not make clear enough. Both of the patches are supposed to be applied. I understand, that white space changes should be separate commits, that is why I provided separate changes. I tested the patches locally, so it is not clear why the fail now.