#39532 closed update (fixed)
pianobar: update to 2013.09.15
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | aguynamedryan+pianobar@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | tresni (Brian Hartvigsen), lpsinger (Leo Singer) |
| Port: | pianobar |
Description
$ port livecheck pianobar pianobar seems to have been updated (port version: 2012.12.01, new version: 2013.05.19)
Attachments (1)
Change History (9)
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Summary: | pianobar: update to 2013.05.19 → pianobar: update to 2013.09.15 |
|---|
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | brian.andrew@… added |
|---|---|
| Keywords: | haspatch added |
Duplicate #40921 has a patch, but I'm worried about all the things it removes. I have a feeling some of it (like UsingTheRightCompiler and -arch flags and adding a universal variant and preventing upgrade errors) is still needed.
comment:3 follow-up: 4 Changed 11 years ago by tresni (Brian Hartvigsen)
You were right to be cautious. After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default. Anyway, here's a much milder patch that doesn't make as many sweeping changes, but still works.
I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-)
Changed 11 years ago by tresni (Brian Hartvigsen)
| Attachment: | pianobar_20130915-1.diff added |
|---|
comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to brian.andrew@…:
After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default.
It is—assuming the port uses an autoconf-compatible configure script. pianobar doesn't (c.f. use_configure no).
I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-)
Or use svn blame and svn log to determine why something is in a Portfile.
comment:7 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r112643, though I see now that the source code is still available on the web site like it was before, and it's bz2 compressed, so I'm not sure why we switched to downloading from github which is gz compressed and thus larger.
comment:8 Changed 11 years ago by tresni (Brian Hartvigsen)
I thought it made the port cleaner and given that even the website indicates that github is the place for up-to-date source/info it made sense to me to switch.