Opened 11 years ago
Closed 11 years ago
#39547 closed defect (fixed)
mlt 0.9.0 remove no_x11 variant
| Reported by: | ddennedy (Dan Dennedy) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | maintainer haspatch | Cc: | |
| Port: | mlt |
Description
Per ticket #39383, this patch converts the mlt port to remove the no_x11 variant (which was actually indirect) and add a gtk2 variant.
Attachments (1)
Change History (5)
Changed 11 years ago by ddennedy (Dan Dennedy)
| Attachment: | mlt-Portfile-39383.diff added |
|---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
No need to put quotes around "--disable-gtk2".
Per comment:ticket:39383:3, the no_x11 variant should remain as a legacy compatibility variant for one year, to help users upgrade to the new variant. Users who had previously indicated their desire for no gtk2 by selecting the no_x11 variant should not now suddenly have gtk2 enabled.
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
On second thought, you're changing the port from having gtk2 on by default to having gtk2 off by default? If that's your intention, then the patch seems fine as is.
comment:3 Changed 11 years ago by ddennedy (Dan Dennedy)
Yes, that was the intention. There is a qt module that provides a similar set of services as gtk2.
comment:4 Changed 11 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
In r110684, sorry for the delay.
drop no_x11 variant, add gtk2 variant