Opened 11 years ago

Closed 11 years ago

#39627 closed submission (fixed)

new: py-lmfit

Reported by: jjstickel (Jonathan Stickel) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: g5pw (Aljaž Srebrnič), smithsp (Sterling Smith)
Port: py-lmfit

Description

New port for the python "lmfit" package. Portfile attached. I created a variant for the optional "unertainties" package, which can be found in ticket #39626.

Attachments (3)

Portfile_py-lmfit (1.5 KB) - added by jjstickel (Jonathan Stickel) 11 years ago.
py-enable_Portfile.diff (1.4 KB) - added by jjstickel (Jonathan Stickel) 11 years ago.
Portfile_py-lmfit.2 (1.5 KB) - added by jjstickel (Jonathan Stickel) 11 years ago.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by jjstickel (Jonathan Stickel)

Attachment: Portfile_py-lmfit added

comment:1 Changed 11 years ago by g5pw (Aljaž Srebrnič)

Thanks for the submission!

Why is your portfile declaring a variant and then just adding a port dependency? I'ts better practice to force the setup script to actually use the port you list as dependency in a variant. Moreover, it looks like the uncertainties package is used just at runtime, so I think users can install the necessary package from MacPorts after installing lmfit. So, declaring a variant is pointless in my opinion, you can add a note about uncertainties if you want, but I wouldn't add a variant since the installed files are the same.

Also, your port is missing a platform keyword. Use the port lint command to check the port file in the future.

comment:2 Changed 11 years ago by g5pw (Aljaž Srebrnič)

Cc: g5pw@… added

Cc Me!

comment:3 Changed 11 years ago by smithsp (Sterling Smith)

The string comparison constructs should be ne instead of !=.

Regarding the uncertainties variant, if the uncertainties package is installed, does lmfit install things any differently?

comment:4 Changed 11 years ago by smithsp (Sterling Smith)

Cc: smithsp@… added

Cc Me!

comment:5 in reply to:  3 Changed 11 years ago by jjstickel (Jonathan Stickel)

Replying to smithsp@…:

Regarding the uncertainties variant, if the uncertainties package is installed, does lmfit install things any differently?

I don't think so. If uncertainties is installed, it can be used for additional calculations. I will remove the variant and add a note, per g5pw's suggestion.

Changed 11 years ago by jjstickel (Jonathan Stickel)

Attachment: py-enable_Portfile.diff added

Changed 11 years ago by jjstickel (Jonathan Stickel)

Attachment: Portfile_py-lmfit.2 added

comment:6 Changed 11 years ago by jjstickel (Jonathan Stickel)

Please review the updated Portfile (ignore py-enable patch - mistaken upload that I can't remove).

comment:7 Changed 11 years ago by g5pw (Aljaž Srebrnič)

Resolution: fixed
Status: newclosed

Ok, I commited your patch in r116239, with the exception of adding a subport for python33, too. I tested the package with python33 and all the examples I could find run fine.

Note: See TracTickets for help on using tickets.