#39787 closed defect (fixed)
pgAdmin3 @1.16.1_0+postgresql92: build failure after update to wxWidgets30 @2.9.5_0
| Reported by: | AP1010 | Owned by: | jyrkiwahlstedt |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | Cc: | mojca (Mojca Miklavec) | |
| Port: | pgAdmin3 |
Description
I upgraded wxWidgets30 to ver. @2.9.5_0. This forced rebuild of pgAdmin3. The rebuild fails with error: pgAdmin3.cpp:1307:20: error: calling a protected constructor of class 'wxStandardPathsCF'
Attachments (3)
Change History (10)
Changed 11 years ago by AP1010
comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)
| Owner: | changed from macports-tickets@… to jwa@… |
|---|---|
| Port: | pgAdmin3 added |
| Summary: | after wxWidgets30 update pgAdmin3 does not build → pgAdmin3 @1.16.1_0+postgresql92: build failure after update to wxWidgets30 @2.9.5_0 |
comment:2 Changed 11 years ago by jeabraham
Same problem. (Me too.)
To get my pgadmin3 working temporarily I did sudo port activate pgadmin3@1.16.0_0 sudo port activate wxWidgets30@2.9.4_2+sdl
I suppose this may be obvious to most of you expert macports people, but maybe someone will come here in desperation having broken their critical pgadmin3 trying to upgrade it. You usually CAN use the old version with macports even if you tried to upgrade.
comment:3 Changed 11 years ago by mojca (Mojca Miklavec)
Citing commit from 6th July:
Forbid creation of wxStandardPaths object directly
This happens to work under MSW and Unix where there is only one wxStandardPaths class for both the console and the GUI applications but doesn't return the correct result under OS X where the Core Foundation version, returned by wxStandardPaths::Get(), has to be used for the GUI programs. And historically this confused a lot of people, so just ensure that they can't accidentally create an object of the wrong type any more.
Closes 13537.
Changed 11 years ago by mojca (Mojca Miklavec)
| Attachment: | patch-pgadmin-pgAdmin3.cpp.diff added |
|---|
A patch for the wxStandardPathsCF compile error
Changed 11 years ago by mojca (Mojca Miklavec)
| Attachment: | patch-wxStandardPaths.diff added |
|---|
A patch for the wxStandardPaths compile error
comment:4 Changed 11 years ago by mojca (Mojca Miklavec)
The second patch (patch-wxStandardPaths.diff) fixes the compile errors for me.
comment:6 Changed 11 years ago by jyrkiwahlstedt
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
done in r108888, thanks for the patch
comment:7 Changed 11 years ago by mojca (Mojca Miklavec)
Thank you. But didn't you forget to add the patch to SVN? Also, given that it has already been fixed (thanks for noticing; I see it now in http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=23c1bc0944468d07e0f54cb43193aaad9e4bbe74;hp=04f90efd7035f6207c7bf917bd753d138e584f84), maybe you could simply add the official patch.
Thanks for the ticket. In the future, please Cc relevant port maintainers.
I guess pgAdmin3 needs to be revbumped when it’s fixed.