Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#39940 closed enhancement (fixed)

apr-util: add mysql variants

Reported by: dr@… Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: haspatch Cc: mp@…, dr@…, cooljeanius (Eric Gallager), ryandesign (Ryan Carsten Schmidt)
Port: apr-util

Description

port info apr-util
apr-util @1.5.2_1 (devel)
Variants:             (+)mysql5, no_bdb, no_sqlite, openldap, postgresql82, postgresql83, postgresql84, universal

Description:          apr-util is a library of useful utilities built with and intended to be used with the Apache Portable Runtime.
Homepage:             http://apr.apache.org/

Library Dependencies: apr, expat, libiconv, db46, sqlite3, mysql5
Platforms:            darwin
License:              Apache-2
Maintainers:          dluke@geeklair.net

There should be a selection for the new mysql5(1|5|6)-Versions..

Attachments (2)

Portfile.patch (1.5 KB) - added by dr@… 11 years ago.
patch-devel-apr-util.diff (2.5 KB) - added by pixilla (Bradley Giesbrecht) 11 years ago.
Add mysql5{1,5,6}, mariadb and percona variants.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 11 years ago by danielluke (Daniel J. Luke)

I don't use mysql at all (and +mysql5 isn't a default variant). I'm happy to accept a patch to add/adjust the +mysql5 behavior, though.

comment:2 Changed 11 years ago by danielluke (Daniel J. Luke)

Owner: changed from macports-tickets@… to dluke@…
Status: newassigned

comment:3 Changed 11 years ago by danielluke (Daniel J. Luke)

Cc: dluke@… removed

comment:4 Changed 11 years ago by dr@…

I attached a patch which adds variants for mysql51, mysql55 and mysql56. :)

Changed 11 years ago by dr@…

Attachment: Portfile.patch added

comment:5 Changed 11 years ago by mp@…

Not sure if variants are the way to go, see #39961

comment:6 in reply to:  4 ; Changed 11 years ago by larryv (Lawrence Velázquez)

Replying to dr@…:

I attached a patch which adds variants for mysql51, mysql55 and mysql56. :)

Could you also add variants for mariadb and percona?

comment:7 Changed 11 years ago by danielluke (Daniel J. Luke)

Does anyone/anything actually use the mysql5 support in apr-util (I'm just curious :) )?

comment:8 in reply to:  5 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to mp@…:

Not sure if variants are the way to go, see #39961

Variants are the way to go. However they should use port: dependencies not path:.

comment:9 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Port: apr-util added
Summary: apr-utils depends on mysql5apr-util: add mysql variants
Type: defectenhancement

comment:10 Changed 11 years ago by mp@…

Cc: mp@… added

Cc Me!

comment:11 in reply to:  7 Changed 11 years ago by dr@…

Replying to dluke@…:

Does anyone/anything actually use the mysql5 support in apr-util (I'm just curious :) )?

Yes. I do ;)

comment:12 in reply to:  6 Changed 11 years ago by dr@…

Replying to larryv@…:

Could you also add variants for mariadb and percona?

Unfortunately, I don't use neither mariadb nor percona..

comment:13 Changed 11 years ago by dr@…

Cc: dr@… added

Cc Me!

comment:14 Changed 11 years ago by danielluke (Daniel J. Luke)

All of the variants in the patch also point to ${prefix}/bin/mysql_config5, which doesn't seem right (since I believe all of the mysql5X ports can be installed at the same time).

Anyone who uses mysql want to provide an updated patch that is working that hopefully has: replaced path: dependencies with port: dependencies, points to whatever is correct for mysql_config5 for each variant, and also has maridb and percona support?

I can commit something if we fix the first two (and it can wait for someone who uses mariadb and/or percona to supply variants for those, if necessary).

Thanks!

comment:15 Changed 11 years ago by pixilla (Bradley Giesbrecht)

I have a patch I will attach after my test builds finish.

Changed 11 years ago by pixilla (Bradley Giesbrecht)

Attachment: patch-devel-apr-util.diff added

Add mysql5{1,5,6}, mariadb and percona variants.

comment:16 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:17 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: assignedclosed

Committed a slightly modified version of pixilla's patch in r112478 (maintainer timeout).

comment:18 Changed 11 years ago by danielluke (Daniel J. Luke)

Thanks Ryan - I could have sworn that I checked this ticket a few times and there was no patch from pixilla yet (and trac doesn't send notifications for attachments, IIRC).

Note: See TracTickets for help on using tickets.