Opened 11 years ago

Closed 11 years ago

#40014 closed submission (fixed)

Create port for py-serpent

Reported by: smithsp (Sterling Smith) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: py-serpent

Description


Attachments (3)

Portfile​ (1.5 KB) - added by smithsp (Sterling Smith) 11 years ago.
Portfile for proposed py-serpent port.
Portfile.2​ (1.2 KB) - added by smithsp (Sterling Smith) 11 years ago.
Improved Portfile to use github.setup
Portfile.3​ (1.2 KB) - added by smithsp (Sterling Smith) 11 years ago.
Latest update of Portfile to update to v1.3.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by smithsp (Sterling Smith)

Attachment: Portfile​ added

Portfile for proposed py-serpent port.

comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)

Keywords: haspatch added

You should use github.setup instead of setting github.author and github.project directly. See py-jedi​, for instance.

comment:2 Changed 11 years ago by mf2k (Frank Schima)

Keywords: haspatch removed

Any submission port does not need, by definition, a haspatch keyword.

Changed 11 years ago by smithsp (Sterling Smith)

Attachment: Portfile.2​ added

Improved Portfile to use github.setup

comment:3 Changed 11 years ago by g5pw (Aljaž Srebrnič)

I took a look, and apart from the fact that it was updated to v1.3 it looks good. I already updated it, and if it's OK I can commit it.

comment:4 Changed 11 years ago by mf2k (Frank Schima)

Same as for the other python ports, since the python portgroup already adds this port to the python category, we prefer to append the other categories. 

categories-append  print

comment:5 in reply to:  3 Changed 11 years ago by smithsp (Sterling Smith)

Replying to g5pw@…:

I took a look, and apart from the fact that it was updated to v1.3 it looks good. I already updated it, and if it's OK I can commit it.

The update to v1.3 happened the day after I submitted the port. Yes it looks good. Please incorporate @macsforever2000's comment that I should use categories-append instead.

Thanks for the help.

Changed 11 years ago by smithsp (Sterling Smith)

Attachment: Portfile.3​ added

Latest update of Portfile to update to v1.3.

comment:6 Changed 11 years ago by g5pw (Aljaž Srebrnič)

Commited in r112743.

comment:7 Changed 11 years ago by g5pw (Aljaž Srebrnič)

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.