Opened 11 years ago

Closed 11 years ago

#40076 closed update (fixed)

libgit2: update to 0.19.0

Reported by: nvenegas@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: libgit2

Description

Changes between 0.17.0 and 0.19.0 are list at https://github.com/libgit2/libgit2/releases

Attachments (1)

upgrade-libgit2-v0.19.0.patch (880 bytes) - added by nvenegas@… 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Type: requestupdate
Version: 2.2.0

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Summary: Upgrade libgit2 to 0.19.0libgit2: update to 0.19.0

What's "github.tarball_from archive"? The only valid values for github.tarball_from are "downloads" and "tags".

comment:3 Changed 11 years ago by nvenegas@…

Ah, good question: I couldn't find documentation on the "github.tarball_from" property, but when I tried "downloads" it 404'd when fetching 0.19.0. Looking at the URL it tried to download from, I noticed that https://github.com/libgit2/libgit2/releases links to https://github.com/libgit2/libgit2/archive/v0.19.0.tar.gz so I thought "archive" would be another valid value.

It seemed to work, but now when I try my Portfile (using "archive") it fetches a binary from http://mse.uk.packages.macports.org/sites/packages.macports.org/libgit2

comment:4 in reply to:  3 Changed 11 years ago by larryv (Lawrence Velázquez)

Replying to nvenegas@…:

It seemed to work, but now when I try my Portfile (using "archive") it fetches a binary from http://mse.uk.packages.macports.org/sites/packages.macports.org/libgit2

Use port -s to force a build from source.

comment:5 Changed 11 years ago by nvenegas@…

With "archive" it fetched from "https://github.com/libgit2/libgit2/tarball/v0.19.0".

With "tags" it also fetched from "https://github.com/libgit2/libgit2/tarball/v0.19.0".

I guess I hit the fall through logic with "archive". I'll update the attached patch.

Changed 11 years ago by nvenegas@…

comment:6 Changed 11 years ago by tomasz.elendt@…

Is there anything missing? The attached fix works for me.

comment:7 Changed 11 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Updated to version 0.20.0 in r115002.

Note: See TracTickets for help on using tickets.