Opened 11 years ago
Closed 7 years ago
#40109 closed enhancement (fixed)
app portgroup support svg app.icon
| Reported by: | elelay (Eric Le Lay) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.0 |
| Keywords: | haspatch | Cc: | cooljeanius (Eric Gallager) |
| Port: |
Description
To have a nice not pixellated icon, it would be nice if the app portgroup could support an svg input for the icon. It would then run librsvg-convert to rasterize it to 16,32,* sizes and finally call makeicns.
Attached is a clumsy patch doing that.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)
| Cc: | egall@… added |
|---|
Changed 11 years ago by elelay (Eric Le Lay)
| Attachment: | rasterize_svg_icon.diff added |
|---|
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Thanks, I haven't tried the patch yet but it looks reasonable.
comment:3 Changed 7 years ago by elelay (Eric Le Lay)
Bump!
If no objection comes in following week, I'll merge this patch (rebasing if necessary).
comment:4 Changed 7 years ago by raimue (Rainer Müller)
depends_build-append should not (no longer?) create duplicates, so that lsearch is not necessary. I would also recommend system -W ${worksrcpath} instead of exec to ensure relative paths always work as expected.
comment:6 Changed 7 years ago by raimue (Rainer Müller)
Looks like I am wrong on the duplicate dependency. The canonical way we use in base is to remove and add it again:
depends_build-delete port:librsvg depends_build-append port:librsvg
comment:7 Changed 7 years ago by elelay (Eric Le Lay)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Cc Me!