Opened 11 years ago

Closed 5 years ago

#40215 closed defect (fixed)

cntlm should not own the cntlm.conf configuration file

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: cntlm

Description

cntlm should not own its config file, as was mentioned in comment:ticket:25796:11. Users are expected to modify config files. Ports should not own files users are expected to modify because upgrading the port would erase any changes the user might have made. Instead, it should own a sample config file, which is installed if not present, and is not touched otherwise. See PortfileRecipes#configfiles

Your claim in comment:ticket:25796:12 that "The Makefile of cntlm already make sure that it don't overwrite the config file if it already exist" is either incorrect or immaterial because the Makefile only controls what gets installed into the destroot; it has no bearing on what MacPorts then copies from the destroot into the final archive. Also, the archive might have been built on our packages server, and then later installed on the user's machine.

Change History (2)

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Owner: jsaucier@… deleted
Status: newassigned

See #58256.

comment:2 Changed 5 years ago by mf2k (Frank Schima)

Owner: set to mf2k
Resolution: fixed
Status: assignedclosed

In 29212ef419d05694bdde621c21141c7651dfdd30/macports-ports (master):

cntlm: Do not overwrite configuration file

  • Add size to checksums

Closes: #40215

Note: See TracTickets for help on using tickets.