Opened 11 years ago

Last modified 11 years ago

#40400 new submission

gogoc @1.2 New submission

Reported by: fabian@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cooljeanius (Eric Gallager)
Port:

Description


Attachments (3)

make.patch​ (2.9 KB) - added by fabian@… 11 years ago.
patch-make.diff​ (2.6 KB) - added by fabian@… 11 years ago.
Portfile​ (2.4 KB) - added by fabian@… 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by fabian@…

Attachment: make.patch​ added

comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)

Just looking at it real quick, the license should be switched to be one of the official ones that MacPorts accepts: ​http://trac.macports.org/wiki/PortfileRecipes#license

Also I'm not on a computer where I can check it myself right now, but port -v lint --nitpick will probably complain about your patchfile name, too...

Edit: Also, why does your makefile patch include the addition of an uninstall target? I thought MacPorts took care of uninstalling for you...

Last edited 11 years ago by cooljeanius (Eric Gallager) (previous) (diff)

comment:2 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 11 years ago by fabian@…

I have problem with uninstall. Macport won't remove the files.

Edit: nevermind,I manage to fix it and removed uninstall in the makefile

Last edited 11 years ago by fabian@… (previous) (diff)

Changed 11 years ago by fabian@…

Attachment: patch-make.diff​ added

Changed 11 years ago by fabian@…

Attachment: Portfile​ added

comment:4 Changed 11 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: new → assigned
Version: 2.2.0

comment:5 Changed 11 years ago by larryv (Lawrence Velázquez)

Owner: changed from larryv@… to macports-tickets@…
Status: assigned → new
Note: See TracTickets for help on using tickets.