metar: add libwww-perl dependency

[xnando@…]

a simple command line metar and taf.

[xnando@…]

metar portfile revision 1. fixed missing dependencies. uploaded diff file.

[larryv (Lawrence Velázquez)]

Replying to xnando@…:

metar portfile revision 1. fixed missing dependencies.

This needs to depend specifically on p5.12-libwww-perl.

[ryandesign (Ryan Carsten Schmidt)]

Replying to larryv@…:

This needs to depend specifically on p5.12-libwww-perl.

Moreover:

$ port notes p5-libwww-perl
p5-libwww-perl has the following notes:
  As of version 6.00, libwww-perl has been broken up into multiple packages. If you were
  using p5-libwww-perl for just one or two of its modules before, you may be able to
  pare down your installation to just those modules now. Other important changes have
  been made that may affect your code; for details, please see:
  /opt/local/share/doc/p5-libwww-perl/Changes

So you may want to depend on something else, not libwww-perl directly.

In addition, metar's shebang line currently reads "#!/usr/bin/perl" meaning it will use OS X perl. So you should reinplace the shebang line to make it use MacPorts perl5.12 instead.

[xnando@…]

I'd like to leave shebang line as it is. it is standard on every unix derived system and i don't care on wich perl it will use.

I'd like to leave also p5-libwww-perl as it is. It is backwards compatible as well as future releases compatible. It simply works.

[larryv (Lawrence Velázquez)]

Replying to xnando@…:

I'd like to leave shebang line as it is. it is standard on every unix derived system and i don't care on wich perl it will use.

This does not make sense. How can it use the system Perl to run but load a Perl module provided by MacPorts?

I'd like to leave also p5-libwww-perl as it is. It is backwards compatible as well as future releases compatible. It simply works.

It’s MacPorts policy for ports that require Perl or a Perl module to depend on a specific version of Perl. The p5-* ports are not intended to be used as dependencies, as all they do is pull in the corresponding p5.12-* ports. And what happens if p5-libwww-perl suddenly changes one day to depend on p5.16-libwww-perl? Will metar just keep working?

We will not accept this patch in its present state.

[xnando@…]

Ok, you convinced me. I will put p5-12-libwww-perl as dependency.

Btw if i change the shebang to "#!/opt/local/bin/perl" do i need to add a sort of perl-lang-core dependency as well ?

[xnando@…]

portfile-metar.diff

[xnando@…]

ok. added p5.12-* dependency. uploaded new .diff portfile.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[kurthindenburg (Kurt Hindenburg)]

I believe this is the way macports is handling perl versions now

[kurthindenburg (Kurt Hindenburg)]

fixed in r123037