Opened 11 years ago
Closed 10 years ago
#40580 closed submission (fixed)
New port: ape
Reported by: | fnog@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.0 |
Keywords: | Cc: | ||
Port: | ape |
Description
Submission of new port: Atomic Pseudopotentials Engine. Port is named "ape".
Attachments (1)
Change History (4)
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 10 years ago by davidfavor (David Favor)
Just checking to see when this will be include in the mainline ports.
comment:3 Changed 10 years ago by dstrubbe (David Strubbe)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in r131693.
Note: See
TracTickets for help on using
tickets.
Thanks. Some observations:
# $Id$
" line is missing. It should be the second line of the portfile, right after the modeline.configure.compiler
, but the port also includes the line "configure.args --with-libxc-prefix=${prefix} FCCPP="${configure.cc} -E -ansi"
". This line will be executed before the variants are evaluated, which means${configure.cc}
will from that moment on be set to its default value (e.g. /usr/bin/clang on modern Xcode versions). To allowconfigure.compiler
to affectconfigure.cc
, ensure that you do not access theconfigure.cc
variable until after the variants are evaluated. That means enclosing this line inside apre-configure
block.ui_msg
line should be removed; it seems like debugging information that users don't need to see.require_active_variants
procedure?