Opened 11 years ago

Closed 10 years ago

Last modified 10 months ago

#40615 closed enhancement (fixed)

clang-3.4 @3.4-r189956_1 Please include clang-format and clang-modernize

Reported by: acmorrow (Andrew C. Morrow) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: pope (K. Adam Christensen), Raimondi (Israel Chauca Fuentes), mamoll (Mark Moll), akimd (Akim Demaille), cdeil (Christoph Deil), hahn.seb@…, john@…, dsvensson@…, larryv (Lawrence Velázquez), dcecchin@…, myint (Steven Myint)
Port: clang-3.4

Description

These clang tools should be either be bundled with clang-3.4, or perhaps placed into separate ports. Either way though, they are very useful and it would be good to see them made available in the MacPorts clang environment.

Attachments (2)

macports_clang-format.patch (7.5 KB) - added by hahn.seb@… 11 years ago.
macports_clang-format-v2.patch (9.5 KB) - added by hahn.seb@… 11 years ago.

Download all attachments as: .zip

Change History (26)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to jeremyhu@…
Version: 2.2.0

In the future, please Cc the port maintainers (port info --maintainers clang-3.4).

comment:2 Changed 11 years ago by pope (K. Adam Christensen)

Cc: pope@… added

Cc Me!

comment:3 Changed 11 years ago by Raimondi (Israel Chauca Fuentes)

Cc: macports@… added

Cc Me!

comment:4 Changed 11 years ago by mamoll (Mark Moll)

Cc: mmoll@… added

Cc Me!

comment:5 Changed 11 years ago by akimd (Akim Demaille)

Cc: akim.demaille@… added

Cc Me!

comment:6 Changed 11 years ago by cdeil (Christoph Deil)

Cc: Deil.Christoph@… added

Cc Me!

comment:7 Changed 11 years ago by slarew

Cc: stephen@… added

Cc Me!

comment:8 Changed 11 years ago by hahn.seb@…

Cc: hahn.seb@… added

Cc Me!

comment:9 Changed 11 years ago by john@…

Cc: john@… added

Cc Me!

comment:10 Changed 11 years ago by dsvensson@…

Cc: dsvensson@… added

Cc Me!

Changed 11 years ago by hahn.seb@…

Attachment: macports_clang-format.patch added

comment:11 Changed 11 years ago by hahn.seb@…

I attached a patch to add a new variant called "format". It places the helper scripts into $prefix/libexec/llvm-3.4/libexec/clang-format/ and the clang-format binary is in $prefix/bin and called clang-format-mp-3.4

comment:12 in reply to:  11 ; Changed 11 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… added

There’s no good reason to provide this as a variant. Might as well install them unconditionally.

comment:13 Changed 11 years ago by dsvensson@…

hanh.seb: How do I use that patch locally?

comment:14 in reply to:  12 Changed 11 years ago by hahn.seb@…

Replying to larryv@…:

There’s no good reason to provide this as a variant. Might as well install them unconditionally.

Some of the bundled scripts require python27, which the port doesn't require already. That's why I didn't make it unconditionally.

comment:15 in reply to:  13 Changed 11 years ago by hahn.seb@…

Replying to dsvensson@…:

hanh.seb: How do I use that patch locally?

That's a bit complicated, but you can find info on that in the macports guide at https://guide.macports.org/

comment:16 Changed 11 years ago by dsvensson@…

I just hacked the Portfile in /opt/... instead, since I wanted it for llvm-3.5. Thanks, hopefully it'll be merged before I need to update that port again.

comment:17 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Please just update the patch to address larryv's comment (no need for the variant), and I'll get it in.

Changed 11 years ago by hahn.seb@…

comment:18 Changed 11 years ago by hahn.seb@…

hrm, it seems notifications are not sent out for attached files, sorry. See above for changed patch.

comment:19 Changed 11 years ago by dcecchin@…

Cc: dcecchin@… added

Cc Me!

comment:20 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Note to self, do #42913 at the same time.

comment:21 Changed 10 years ago by myint (Steven Myint)

Cc: general@… added

Cc Me!

comment:22 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed

r120439 r120440

Please file a new ticket with a patch if you want clang-modernize as well. I made the clang_select change in preparation for it.

comment:23 Changed 10 years ago by mamoll (Mark Moll)

I created ticket #43839 for clang-modernize.

comment:24 Changed 10 months ago by slarew

Cc: slarew removed
Note: See TracTickets for help on using tickets.