Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#40813 closed defect (fixed)

Fix mp4v2 to build with clang

Reported by: lennart.macports@… Owned by: 0xced (Cédric Luthi)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: mavericks Cc: jeremyhu (Jeremy Huddleston Sequoia), danchr (Dan Villiom Podlaski Christiansen), chbperso@…, robin@…, ryandesign (Ryan Carsten Schmidt)
Port: mp4v2

Description

mp4v2's portfile is explicitly disabling builds under OS X 10.9 Mavericks, but as far as I can tell, it builds fine with 10.9 GM + Xcode 5.0:

$ port install mp4v2
--->  Computing dependencies for mp4v2
--->  Fetching distfiles for mp4v2
Error: mp4v2 does not build on Mavericks or later.
Error: org.macports.fetch for port mp4v2 returned: unsupported platform
Please see the log file for port mp4v2 for details:
    /opt/macports/var/macports/logs/_opt_macports_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_mp4v2/mp4v2/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
$ port edit mp4v2   # removing Mavericks build restriction
$ port install mp4v2
Portfile changed since last build; discarding previous state.
--->  Cleaning mp4v2
--->  Updating database of binaries: 100.0%
--->  Scanning binaries for linking errors: 100.0%
--->  No broken files found.
$ port uninstall mp4v2   # uninstalling & reinstalling just to double check
--->  Deactivating mp4v2 @1.9.1_2
--->  Cleaning mp4v2
--->  Uninstalling mp4v2 @1.9.1_2
--->  Cleaning mp4v2
$ port install mp4v2
--->  Computing dependencies for mp4v2
--->  Fetching distfiles for mp4v2
--->  Attempting to fetch mp4v2-1.9.1.tar.bz2 from http://distfiles.macports.org/mp4v2
--->  Verifying checksums for mp4v2
--->  Extracting mp4v2
--->  Applying patches to mp4v2
--->  Configuring mp4v2
--->  Building mp4v2
--->  Staging mp4v2 into destroot
--->  Installing mp4v2 @1.9.1_2
--->  Activating mp4v2 @1.9.1_2
--->  Cleaning mp4v2
--->  Updating database of binaries: 100.0%
--->  Scanning binaries for linking errors: 100.0%
--->  No broken files found.
$ mp4info Wake\ Skating\ Cranberries.mp4 
mp4info version 1.9.1
Wake Skating Cranberries.mp4:
Track	Type	Info
1	video	H264 High@4, 481.439 secs, 4488 kbps, 1920x1080 @ 23.976039 fps
2	audio	MPEG-4 AAC LC, 481.493 secs, 0 kbps, 48000 Hz
$ # looks good
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.9
BuildVersion:	13A598
$ xcodebuild -version
Xcode 5.0
Build version 5A1413

Attachments (1)

my-ports-655a26c17d5747395029c29e874c3972a507407b.diff (3.1 KB) - added by danchr (Dan Villiom Podlaski Christiansen) 11 years ago.
Patch for bumping to 2.0.0.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by lennart.macports@…

Cc: lennart.macports@… added

Cc Me!

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: jeremyhu@… added; lennart.macports@… removed
Keywords: mavericks added
Owner: changed from macports-tickets@… to cedric.luthi@…

comment:3 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Summary: mp4v2 + mavericks = okFix mp4v2 to build with clang

It is properly blacklisted. Mavericks is still under NDA.

Changed 11 years ago by danchr (Dan Villiom Podlaski Christiansen)

Patch for bumping to 2.0.0.

comment:4 in reply to:  3 Changed 11 years ago by danchr (Dan Villiom Podlaski Christiansen)

Replying to jeremyhu@…:

It is properly blacklisted. Mavericks is still under NDA.

That's no longer the case, fortunately. The attached patch resolves this on my machine by bumping mp4v2 to 2.0.0.

comment:5 Changed 11 years ago by mschout@…

+1 patch fixes for me also.

comment:6 Changed 11 years ago by danchr (Dan Villiom Podlaski Christiansen)

Cc: danchr@… added

Cc Me!

comment:7 Changed 11 years ago by chbperso@…

Cc: chbperso@… added

Cc Me!

comment:8 Changed 11 years ago by robin@…

Cc: robin@… added

Cc Me!

comment:9 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed

comment:10 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

You didn't increase the revision or version of mp4v2-devel so users who had it installed will not be prompted to upgrade. Fixed in r113986.

The patch you've left for Darwin < 10 does not apply. A patch to fix it had previously been submitted in #38046; I'll address it there.

Note: See TracTickets for help on using tickets.