Opened 11 years ago

Closed 11 years ago

#40821 closed update (fixed)

py-dpkt: update to 1.8 and add py27 subport

Reported by: aeppert@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: py-dpkt

Description


Attachments (1)

Portfile (1003 bytes) - added by aeppert@… 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Thanks for the submission. This Portfile needs to be updated to use the unified python 1.0 portgroup. See almost any other python port for guidance, but py-pil should be a good example.

comment:2 in reply to:  1 Changed 11 years ago by aeppert@…

Replying to macsforever2000@…:

Thanks for the submission. This Portfile needs to be updated to use the unified python 1.0 portgroup. See almost any other python port for guidance, but py-pil should be a good example.

I apologize for the oversight. The updated Portfile has been attached.

Changed 11 years ago by aeppert@…

Attachment: Portfile added

comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: py-dpkt added; py27-dpkt removed
Status: newassigned
Summary: Python 2.7 DPKT 1.8py-dpkt: update to 1.8 and add py27 subport
Type: submissionupdate

py-dpkt already exists; it was created 6.5 years ago in r22777.

Perhaps you're just asking for it to be updated to version 1.8 and for a py27 subport to be added to it?

comment:4 Changed 11 years ago by aeppert@…

Actually, I updated the py-dpkt Portfile to python 1.0 portgroup per macsforever200's comment. The one referenced in r22777 is py24 centric, plus I updated it to 1.8.

Several things going on there really. The original subject was confusing, I realize now and given I learned about the updated python 1.0 portgroup.

The Portfile submitted is a bulk replacement.

comment:5 in reply to:  4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to aeppert@…:

Actually, I updated the py-dpkt Portfile to python 1.0 portgroup per macsforever200's comment. The one referenced in r22777 is py24 centric, plus I updated it to 1.8.

I'm aware of that. The py-dpkt port has been updated many times since its original submission and has already been using the python 1.0 portgroup since r102033.

Several things going on there really. The original subject was confusing, I realize now and given I learned about the updated python 1.0 portgroup.

The Portfile submitted is a bulk replacement.

For updates to existing ports, we would like to receive unified diffs, not complete new portfiles, as explained in our guide.

I added a py27 subport and disabled livecheck on subports in r112387. I did not yet update to 1.8 because it doesn't build on python 2.4 so we may need to keep the py24 subport at version 1.7.

comment:6 Changed 11 years ago by aeppert@…

Honestly, the ports tree is exceptionally confusing as it stands. If there need be a 1.7 tree, fine, but given 1.8 is out, and someone (me) sent in a patch, there is use for it and I would imagine I am not alone.

How that is handled, isn't my concern ultimately,as I simply was trying to help return a favor to the community. If that isn't helpful, I apologize creating work isn't my goal.

comment:7 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thank you for bringing the matter to our attention and for trying to fix it. I've updated the py25 and later subports to 1.8 in r112393 while keeping the py24 subport at 1.7, and I filed a bug report with the developers to determine if this change was intentional (their changelog doesn't mention it).

Sorry that some of MacPorts is still a bit confusing; we do have a tendency to add features and not document them well. If you have further questions about how MacPorts works, you can ask on the macports-dev mailing list which is populated with many MacPorts contributors who can answer your questions.

Note: See TracTickets for help on using tickets.