Opened 11 years ago
Closed 6 years ago
#40955 closed submission (fixed)
Please add port ADOL-C
Reported by: | kurtjaeke@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.0 |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) | |
Port: | ADOL-C |
Description
Please add the ADOL-C port. ADOL-C is a library that implements Algorithmic Differentiation by Operator overLoading for C, see http://www.coin-or.org/projects/ADOL-C.xml.
Minimal working Portfile attached.
Attachments (3)
Change History (8)
Changed 11 years ago by kurtjaeke@…
comment:1 follow-up: 2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|---|
Port: | ADOL-C added |
Thanks. Some observations:
- The modeline and $Id$ lines are missing.
- "universal_variant yes" is the default and can be removed.
- "--disable-dependency-tracking" is added by default when the universal variant is used and is generally not needed when not building universal.
- Unless this configure script is weird, "--libdir=${prefix}/lib" and "--libexecdir=${prefix}/libexec" are the defaults too.
- Livecheck doesn't work.
- "--disable-silent-rules" should be added to configure args to make debug output more verbose.
- It seemed to build fine with ccache so "configure.ccache no" could be removed.
Also, you have indicated "license BSD" but the file LICENSE in the source tarball begins as follows:
THIS PROGRAM IS PROVIDED UNDER THE TERMS OF ONE OF THE TWO LICENSES, I.E., EITHER THE ECLIPSE PUBLIC LICENSE VERSION 1.0 OR THE GNU GENERAL PUBLIC LICENSE AS GIVEN BELOW. ANY USE, REPRODUCTION OR DISTRIBUTION OF THE PROGRAM CONSTITUTES THE RECIPIENT'S ACCEPTANCE OF ONE OF THE TWO AGREEMENTS EPL-1.0 OR GPL-2.0+.
And the project's homepage says: "Project license: Eclipse Public License 1.0 or GNU Gerneral Public License 2.0"
So I've attached a new version of the Portfile with these changes.
Remaining issues I'd want to fix:
- The configure script prints an unnecessary warning about needing the prefix to be writable.
- After the configure phase successfully runs the configure script, the build phase runs it again; I don't yet understand why.
Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | Portfile.2 added |
---|
comment:2 Changed 11 years ago by kurtjaeke@…
Replying to ryandesign@…:
- Unless this configure script is weird, "--libdir=${prefix}/lib" and "--libexecdir=${prefix}/libexec" are the defaults too.
The configure script is weird. It will install to lib64 unless overridden explicitly. See new attachment, which adds these two lines to your Portfile.
Remaining issues I'd want to fix:
- The configure script prints an unnecessary warning about needing the prefix to be writable.
- After the configure phase successfully runs the configure script, the build phase runs it again; I don't yet understand why.
I think these issues can only be fixed upstream.
comment:4 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Cc: | MarcusCalhoun-Lopez added |
---|
comment:5 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Resolution: | → fixed |
---|---|
Status: | new → closed |
ADOL-C has been added.
Minimal Portfile.