Opened 11 years ago
Closed 10 years ago
#41167 closed enhancement (fixed)
ola: Add a +nowarnings variant to work around issues with the new compiler
Reported by: | nomis52@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | haspatch maintainer | Cc: | cooljeanius (Eric Gallager), ryandesign (Ryan Carsten Schmidt) |
Port: | ola |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
The new compiler that comes with XCode 5 is failing with :
#warning Use of the header <ext/hash_map> is deprecated.
This variant disables fatal warnings (-Werror
) so users can continue to build until the next release with the fixes is out.
Attachments (1)
Change History (6)
Changed 11 years ago by nomis52@…
Attachment: | Portfile.diff added |
---|
comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)
comment:2 Changed 11 years ago by nomis52@…
We want to detect potential bugs early. We took the decision as a project to fail on warnings so that we find out about the problem. It's been working well for us.
comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Summary: | Add a +nowarnings variant to work around issues with the new compiler → ola: Add a +nowarnings variant to work around issues with the new compiler |
---|
We don't want users to encounter errors building. We should disable -Werror
all the time. That's the decision we've taken as a project. :)
comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|---|
Description: | modified (diff) |
Resolution: | → fixed |
Status: | new → closed |
ola @0.9.2 fails to build on the 10.7 and 10.8 buildslaves, with this error:
clang: error: argument unused during compilation: '-pthread'
An unused argument would normally only be a warning, but -Werror
is turning the warning into an error.
I've disabled the use of -Werror
in r124835.
Why don’t you just use
--disable-fatal-warnings
all the time? It is generally not useful to use-Werror
for end-user builds.