#41499 closed enhancement (fixed)
py26-pyke @1.1.1: make it a unified py-pyke port
Reported by: | petrrr | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | mahergamal@…, jmroot (Joshua Root), mojca (Mojca Miklavec) |
Port: | py-pyke py26-pyke |
Description
I propose to use the unified PortGroup for this port to add py27
and py3x
to it.
Some time ago I created such a unified port, because I needed it as a dependence. I than realised that the py26-pyke
version already exists. The differences are minor, but I propose some changes (as detailed below) here so I just submit my Portfile
as is for review, I can provide diffs if this is considered useful in this case (py26-pyke
is to be replaces py-pyke
). The maintainer probably should stay with mahergamal@gmail.com
.
The differences are:
- use unified PortGroup;
- add py27 py32 py33 py34
- add
license
andsupported_archs noarch
; - the description is slightly different;
- remove lib dependency;
The dependency htmltemplate
is used only for examples, so it should not be a dependency (or at best a depends_run
).
Attachments (1)
Change History (8)
Changed 11 years ago by petrrr
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | jmr@… added; jmr removed |
---|
comment:2 Changed 11 years ago by mojca (Mojca Miklavec)
I'm working on this now, just a question: the original port has
depends_lib port:py26-htmltemplate
What's with this dependency?
comment:3 Changed 11 years ago by mojca (Mojca Miklavec)
Sorry, I just read that in description. I'm not sure whether or not to add depends_run
now. In any case one would need to fix the dependency to support more versions of Python.
comment:4 Changed 11 years ago by petrrr
I concluded I is not necessary, see also above. htmltemplate
is required only for the examples not even tests. At best this would qualify for a runtime dependency, but I just would not put it.
EDIT: it is documented in README or INSTALL.
comment:5 Changed 11 years ago by mojca (Mojca Miklavec)
Resolution: | → fixed |
---|---|
Status: | new → closed |
r114092. I assumed maintainer timeout, but also added you as the co-maintainer. If the original author disagrees or if you disagree with the change, let me know.
I had to add
worksrcdir pyke-${version}
else the build failed, trying to find the dir work/pyke3-1.1.1
.
comment:7 Changed 11 years ago by petrrr
Thanks for having work on this and for spotting the bug. I tested py3 as well, but probably did some "minor" change on the py3 logic and broke it unintentionally.
The Portfile for python/py-pyke.