Opened 11 years ago

Closed 9 years ago

#41562 closed defect (fixed)

libbonoboui @2.24.5: error: format string is not a string literal [-Werror,-Wformat-nonliteral]

Reported by: allamistakeo18@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: mavericks Cc: brian.c.hill@…, MartinBuchmann (Martin Buchmann), onurdomanic@…, bouttier__macports@…, 4eppelin@…, kajh, jgmath2000@…
Port: libbonoboui

Description (last modified by ryandesign (Ryan Carsten Schmidt))

I'm trying to install gnucash on Mavericks, after upgrading from Lion.

My first attempt failed when building pulseaudio returned an error, as documented in this other ticket: #41415

So now, I just renamed my /opt/ and /Applications/MacPorts/ folders, reinstalled MacPorts from scratch (instead of attempting to upgrade my Lion installation), and when I try to install gnucash, this time it fails to build libbonoboui. See attached log file.

Attachments (3)

main.log (156.4 KB) - added by allamistakeo18@… 11 years ago.
main.2.log (386.5 KB) - added by rjderosa (Robert De Rosa) 11 years ago.
clean attempt
libbonobo.patch (1.9 KB) - added by christian@… 11 years ago.

Download all attachments as: .zip

Change History (25)

Changed 11 years ago by allamistakeo18@…

Attachment: main.log added

comment:1 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Keywords: mavericks added

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Keywords: gnucash libbonoboui removed

This was not a clean attempt. Please clean and try again.

Changed 11 years ago by rjderosa (Robert De Rosa)

Attachment: main.2.log added

clean attempt

comment:3 in reply to:  2 Changed 11 years ago by rjderosa (Robert De Rosa)

Replying to ryandesign@…:

This was not a clean attempt. Please clean and try again.

It doesn't build on Mavericks after cleaning.

comment:4 Changed 11 years ago by rjderosa (Robert De Rosa)

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Probably a very dirty way to get it to build, but gnucash doesn't seem to complain (yet).

comment:5 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: brian.c.hill@… added
Summary: libbonoboui fails to build on Maverickslibbonoboui @2.24.5: error: format string is not a string literal [-Werror,-Wformat-nonliteral]

Has duplicate #41584.

comment:6 in reply to:  4 ; Changed 11 years ago by allamistakeo18@…

Replying to rderosa86@…:

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Can you please clarify what you did exactly? I removed that flag from the Makefile but I still can't get it to build.

comment:7 Changed 11 years ago by jmroot (Joshua Root)

Some of those warning flags don't occur anywhere in the source, so I would guess they're coming from the .pc file of one or more dependencies. Putting -Werror in flags intended to be used by other programs is, of course, a really bad idea.

comment:8 Changed 11 years ago by jmroot (Joshua Root)

They don't seem to be coming from pkg-config either. Maybe the autoreconf is adding them?

comment:9 Changed 11 years ago by MartinBuchmann (Martin Buchmann)

Cc: Martin.Buchmann@… added

Cc Me!

comment:10 in reply to:  6 ; Changed 11 years ago by rjderosa (Robert De Rosa)

Replying to allamistakeo18@…:

Replying to rderosa86@…:

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Can you please clarify what you did exactly? I removed that flag from the Makefile but I still can't get it to build.

I'm not sure how I could clarify that further. I think there is only one instance of -Werror=format=2 flag in the makefile.

comment:11 in reply to:  10 Changed 11 years ago by allamistakeo18@…

Replying to rderosa86@…:

I'm not sure how I could clarify that further. I think there is only one instance of -Werror=format=2 flag in the makefile.

Got it. I was editing the wrong Makefile. Now I also got it to compile.

comment:12 Changed 11 years ago by onurdomanic@…

Cc: onurdomanic@… added

Cc Me!

comment:13 Changed 11 years ago by rmonv@…

Got it to compile by editing the configure file that generates the Makefiles in the same way as rderosa86 did

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_libbonoboui/libbonoboui/work//libbonoboui-2.24.5/configure

comment:14 Changed 11 years ago by bouttier__macports@…

Cc: bouttier__macports@… added

Cc Me!

comment:15 Changed 11 years ago by kajh

Cc: kaj.hejer@… added

Cc Me!

comment:16 Changed 11 years ago by 4eppelin@…

Cc: 4eppelin@… added

Cc Me!

comment:17 Changed 11 years ago by kajh

Cc: kaj.hejer@… removed

Cc Me!

comment:18 Changed 11 years ago by kajh

Cc: kaj.hejer@… added

Cc Me!

comment:19 Changed 11 years ago by josephsacco

GCC is smart enough not to issue a warning when calling a printf function using a va_list; clang is not. See:

http://comments.gmane.org/gmane.linux.arch.pacman.devel/10278

for a possible work-around.

Needless to say, libbonoboui does build using gcc-4.8.x

-Joseph

Last edited 11 years ago by josephsacco (previous) (diff)

Changed 11 years ago by christian@…

Attachment: libbonobo.patch added

comment:20 Changed 11 years ago by christian@…

I got it to compile with the attached patch. The solution comes form an answer to the post linked by drjesacco above.

comment:21 Changed 11 years ago by jgmath2000@…

Cc: jgmath2000@… added

Cc Me!

comment:22 Changed 9 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Fix committed in r115037

Note: See TracTickets for help on using tickets.