Opened 11 years ago
Closed 11 years ago
#41829 closed enhancement (invalid)
qhull: Add a port variant to allow for using libqhullcpp
| Reported by: | litherum@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | Cc: | mamoll (Mark Moll), ryandesign (Ryan Carsten Schmidt) | |
| Port: | qhull |
Description
Using the C++ interface to libqhull (libqhullcpp) requires a particular option be set which allows for accessing globals via a pointer rather than directly. This option is in the form of a #define inside qhull's user.h file (which is used for "user redefinable constants.") The attached patch adds a variant which turns on this option.
Attachments (2)
Change History (5)
Changed 11 years ago by litherum@…
| Attachment: | Portfile.diff added |
|---|
Changed 11 years ago by litherum@…
| Attachment: | patch-global-pointer-indirection.diff added |
|---|
Patch for src/libqhull/user.h
comment:2 Changed 11 years ago by litherum@…
Looks like the libqhull-p.dylib file solves this problem (requires also setting the -Dqh_QHpointer=1 flag). You can go ahead and mark this as "working as intended"
comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | mmoll@… ryandesign@… added; litherum@… removed |
|---|---|
| Port: | qhull added |
| Resolution: | → invalid |
| Status: | new → closed |
| Summary: | Add a port variant to qhull to allow for using libqhullcpp → qhull: Add a port variant to allow for using libqhullcpp |
Ok good, because adding a variant for a feature that other projects might need to depend on is not a good idea; such a feature should either be always enabled or should be implemented as a subport, not a variant.
Patch for the Portfile