tao @6.2.3: fails to build on Mavericks: cannot convert 'const Test::S4' to 'unsigned char'

[mojca (Mojca Miklavec)]

See: ​http://build.macports.org/builders/buildports-mavericks-x86_64/builds/408

In file included from structC.cpp:32:
In file included from ./structC.h:45:
In file included from ../../tao/AnyTypeCode/AnyTypeCode_methods.h:30:
In file included from ../../tao/Basic_Types.h:24:
In file included from ../../tao/orbconf.h:24:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Condition_Thread_Mutex.h:30:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Thread_Mutex.h:31:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_Thread.h:2049:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_Thread.inl:8:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_sys_mman.h:93:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_sys_mman.inl:7:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_stdio.h:560:
/opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_stdio.inl:887:41: warning: 'tempnam' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of tempnam(3), it is highly recommended that you use mkstemp(3) instead. [-Wdeprecated-declarations]
  ACE_OSCALL_RETURN (ACE_STD_NAMESPACE::tempnam (dir, pfx), char *, 0);
                                        ^
/opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/config-macros.h:312:20: note: expanded from macro 'ACE_OSCALL_RETURN'
    return (TYPE) (X); \
                   ^
/usr/include/stdio.h:389:7: note: 'tempnam' declared here
char    *tempnam(const char *, const char *) __DARWIN_ALIAS(tempnam);
         ^
In file included from structC.cpp:32:
In file included from ./structC.h:45:
In file included from ../../tao/AnyTypeCode/AnyTypeCode_methods.h:30:
In file included from ../../tao/Basic_Types.h:24:
In file included from ../../tao/orbconf.h:24:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Condition_Thread_Mutex.h:30:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Thread_Mutex.h:31:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_Thread.h:33:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Base_Thread_Adapter.h:17:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_Log_Msg_Attributes.h:25:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/iosfwd.h:39:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/streams.h:58:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iostream:38:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/ios:216:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__locale:15:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/string:434:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1795:32: error: cannot convert 'const Test::S4' to 'unsigned char' without a conversion operator
        _VSTD::memset(__first, (unsigned char)__value_, (size_t)(__n));
                               ^~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1804:11: note: in instantiation of function template specialization 'std::__1::__fill_n<Test::S4 *, long, Test::S4>' requested here
   return _VSTD::__fill_n(__first, __n, __value_, integral_constant<bool,
          ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1826:5: note: in instantiation of function template specialization 'std::__1::fill_n<Test::S4 *, long, Test::S4>' requested here
    _VSTD::fill_n(__first, __last - __first, __value_);
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1834:5: note: in instantiation of function template specialization 'std::__1::__fill<Test::S4 *, Test::S4>' requested here
    _VSTD::__fill(__first, __last, __value_, typename iterator_traits<_ForwardIterator>::iterator_category());
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
../../tao/Value_Traits_T.h:40:5: note: in instantiation of function template specialization 'std::__1::fill<Test::S4 *, Test::S4>' requested here
    std::fill(begin, end, value_type ());
    ^
../../tao/Generic_Sequence_T.h:155:21: note: in instantiation of member function 'TAO::details::value_traits<Test::S4, true>::initialize_range' requested here
    element_traits::initialize_range(
                    ^
../../tao/Unbounded_Value_Sequence_T.h:24:7: note: in instantiation of member function 'TAO::details::generic_sequence<Test::S4, TAO::details::unbounded_value_allocation_traits<Test::S4, true>, TAO::details::value_traits<Test::S4, true> >::generic_sequence' requested here
class unbounded_value_sequence
      ^
In file included from structC.cpp:32:
In file included from ./structC.h:45:
In file included from ../../tao/AnyTypeCode/AnyTypeCode_methods.h:30:
In file included from ../../tao/Basic_Types.h:24:
In file included from ../../tao/orbconf.h:24:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Condition_Thread_Mutex.h:30:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Thread_Mutex.h:31:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_NS_Thread.h:33:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/Base_Thread_Adapter.h:17:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/OS_Log_Msg_Attributes.h:25:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/iosfwd.h:39:
In file included from /opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/ace/streams.h:58:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iostream:38:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/ios:216:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__locale:15:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/string:434:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1795:32: error: cannot convert 'const Test::S5' to 'unsigned char' without a conversion operator
        _VSTD::memset(__first, (unsigned char)__value_, (size_t)(__n));
                               ^~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1804:11: note: in instantiation of function template specialization 'std::__1::__fill_n<Test::S5 *, long, Test::S5>' requested here
   return _VSTD::__fill_n(__first, __n, __value_, integral_constant<bool,
          ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1826:5: note: in instantiation of function template specialization 'std::__1::fill_n<Test::S5 *, long, Test::S5>' requested here
    _VSTD::fill_n(__first, __last - __first, __value_);
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:1834:5: note: in instantiation of function template specialization 'std::__1::__fill<Test::S5 *, Test::S5>' requested here
    _VSTD::__fill(__first, __last, __value_, typename iterator_traits<_ForwardIterator>::iterator_category());
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__config:300:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_NAMESPACE
              ^
../../tao/Value_Traits_T.h:40:5: note: in instantiation of function template specialization 'std::__1::fill<Test::S5 *, Test::S5>' requested here
    std::fill(begin, end, value_type ());
    ^
../../tao/Generic_Sequence_T.h:155:21: note: in instantiation of member function 'TAO::details::value_traits<Test::S5, true>::initialize_range' requested here
    element_traits::initialize_range(
                    ^
../../tao/Unbounded_Value_Sequence_T.h:24:7: note: in instantiation of member function 'TAO::details::generic_sequence<Test::S5, TAO::details::unbounded_value_allocation_traits<Test::S5, true>, TAO::details::value_traits<Test::S5, true> >::generic_sequence' requested here
class unbounded_value_sequence
      ^
2 warnings and 2 errors generated.
make[1]: *** [.shobj/structC.o] Error 1
make: *** [IDL_Test_DLL] Error 2
Command failed:  cd "/opt/local/var/macports/build/_opt_mports_dports_devel_tao/tao/work/ACE_wrappers/TAO" && /usr/bin/make INSTALL_PREFIX=/opt/local all CC=/usr/bin/clang CXX=/usr/bin/clang++ CPP=/usr/bin/cpp 
Exit code: 2

[lockhart (Thomas Lockhart)]

This appears to be the same symptom as a bug reported for LLVM: ​http://llvm.org/bugs/show_bug.cgi?id=16764 This is marked as having been fixed in the compiler but apparently Mavericks does not yet have the newer compiler code. How do we handle problem reports traced back to upstream dependencies?

[lockhart (Thomas Lockhart)]

Another workaround would be to build only a subset of the TAO sources. I have done this in the past and one could make a very good argument that test cases such as the one failing here should not be compiled as part of a production package since they do not end up in the installation anyway. Will try testing a subset build and if successful will push a patch here to try on Mavericks.

[lockhart (Thomas Lockhart)]

Build a subset of TAO omitting tests and examples

[lockhart (Thomas Lockhart)]

Per comment from a couple of hours ago, find a patch attached to build a subset of the ACE/TAO tree. This omits examples and test cases (including the test cases failing with the current Mavericks compiler) but includes all code and libraries required for development using ACE and TAO.

[mojca (Mojca Miklavec)]

Committed in r115405.