Opened 11 years ago

Closed 11 years ago

#42001 closed update (fixed)

py-suds-jurko @0.4.1.jurko.4: update to 0.5

Reported by: patrik.hartlen@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: py-suds-jurko

Description

Hi,

I want to update pt-suds-jurko from 0.4.1 to 0.5 and which is now also available at pypi so I have also updated the source site. Patchfile is attached.

thanks Patrik

Attachments (3)

Portfile-py-suds-jurko.diff (3.0 KB) - added by patrik.hartlen@… 11 years ago.
Portfile-py-suds-jurko-ws.diff (2.7 KB) - added by patrik.hartlen@… 11 years ago.
Portfile-py-suds-jurko-fnc.diff (924 bytes) - added by patrik.hartlen@… 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by patrik.hartlen@…

Attachment: Portfile-py-suds-jurko.diff added

comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: newassigned
Summary: Upgrade py-suds-jurkopy-suds-jurko @0.4.1.jurko.4: update to 0.5
Version: 2.2.1

Thanks, but this patch mixes whitespace/formatting changes and functional changes. Please provide the whitespace changes in one patch that applies to the existing Portfile, and provide the formatting changes in another patch that applies over the whitespace patch.

Changed 11 years ago by patrik.hartlen@…

Changed 11 years ago by patrik.hartlen@…

comment:2 in reply to:  1 ; Changed 11 years ago by patrik.hartlen@…

Replying to larryv@…:

Thanks, but this patch mixes whitespace/formatting changes and functional changes. Please provide the whitespace changes in one patch that applies to the existing Portfile, and provide the formatting changes in another patch that applies over the whitespace patch.

I have attached two new patch files. Use Portfile-py-suds-jurko-ws.diff​ first to fix whitespace according to standard port files and then Portfile-py-suds-jurko-fnc.diff​ to apply the functional changes to version 0.5 and pypi.

/Patrik

comment:3 in reply to:  2 ; Changed 11 years ago by larryv (Lawrence Velázquez)

Thanks, I appreciate it.

The new Portfile omits python.default_version (thus defaulting to Python 2.4 instead of 2.7) and removes the dependency on setuptools. Are these changes intentional?

comment:4 in reply to:  3 ; Changed 11 years ago by patrik.hartlen@…

Replying to larryv@…:

Thanks, I appreciate it.

The new Portfile omits python.default_version (thus defaulting to Python 2.4 instead of 2.7) and removes the dependency on setuptools. Are these changes intentional?

It's probably my mistake I thought it defaulted to 2.7, a quick scan in Python ports shows that 154 of 969 uses python.default_version so I omitted it. But if it should be there I can replace the patch Portfile-py-suds-jurko-fnc.diff​ to include the default version.

comment:5 in reply to:  4 Changed 11 years ago by larryv (Lawrence Velázquez)

Keywords: maintainer added
Resolution: fixed
Status: assignedclosed

You’re close. For historical reasons, python.default_version defaults to “24” if python.versions includes “24”; otherwise, it’s “27”.

Updated in r115504. I left the setuptools dependency because the build will download it if it’s not already present, and we don’t want that.

Note: See TracTickets for help on using tickets.