Opened 11 years ago

Closed 11 years ago

#42077 closed enhancement (fixed)

Enhancement for Silo: Add variant to install PDB Lite support

Reported by: ghweber@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: silo

Description

Add a new variant to Silo to install it with PDB Lite support headers.

Attachments (2)

Portfile-silo.2.diff (2.5 KB) - added by ghweber@… 11 years ago.
Revised diff for portfile (remove variant, enable shared, add gcc versions)
Portfile-silo.diff (2.5 KB) - added by ghweber@… 11 years ago.
Revised diff for portfile (remove variant, enable shared, add gcc versions)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Keywords: haspatch added
Port: silo added; Silo removed
Version: 2.2.1

Is there a reason you are making this into a variant? Why not just always enable support for PDB lite?

comment:2 Changed 11 years ago by ghweber@…

Only reason was minimal intrusiveness for those having installed it. There shouldn't be any harm in enabling the headers. If further changes are ok, I'd also enable building of shared libraries and update to Silo 4.9.1. I'd be happy to update the Portfile accordingly.

comment:3 Changed 11 years ago by mf2k (Frank Schima)

Please do then. Users would, of course, have to update for the new version anyway, we can add the PDB lite functionality at the same time. I don't know about the (dis)advantages of enabling shared libraries, but go ahead and add them if you think it is best. To add to the list, variants for gcc48 (the Macports default) and gcc49 should be added to keep up to date too.

Changed 11 years ago by ghweber@…

Attachment: Portfile-silo.2.diff added

Revised diff for portfile (remove variant, enable shared, add gcc versions)

Changed 11 years ago by ghweber@…

Attachment: Portfile-silo.diff added

Revised diff for portfile (remove variant, enable shared, add gcc versions)

comment:4 in reply to:  3 Changed 11 years ago by ghweber@…

Replying to macsforever2000@…:

Please do then. Users would, of course, have to update for the new version anyway, we can add the PDB lite functionality at the same time. I don't know about the (dis)advantages of enabling shared libraries, but go ahead and add them if you think it is best. To add to the list, variants for gcc48 (the Macports default) and gcc49 should be added to keep up to date too.

I updated the patch to the Portfile. It now uses the most recent version of Silo and enables PDB lite headers and shared libraries. I also added variants for gcc48 and gcc49 based on what I saw on other ports but did not test these variants.

comment:5 Changed 11 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.